Differential D58839

asmc: prefer MMIO backend over PIO when both are present
ClosedPublic
Actions

Authored by guest-seuros on Fri, Aug 14, 8:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 17, 11:53 AM

	Unknown Object (File)
	Sun, Aug 16, 12:17 PM

	Unknown Object (File)
	Sat, Aug 15, 12:54 PM

	Unknown Object (File)
	Sat, Aug 15, 12:46 PM

	Unknown Object (File)
	Fri, Aug 14, 7:03 PM

	Unknown Object (File)
	Fri, Aug 14, 7:00 PM

	Unknown Object (File)
	Fri, Aug 14, 11:19 AM

Subscribers

Details

Reviewers

ngie
adrian

Commits

rG37826269b41b: asmc: prefer MMIO backend over PIO when both are present

Summary

T2, T1, and some pre-T1 Macs advertise a legacy PIO
range in the SMC ACPI _CRS alongside a live MMIO window, but the
silicon behind the PIO range is bogus.

Try MMIO first, validate via LDKN >= 2, fall back to PIO if that
fails or no MMIO resource is present. Drop "(T2)" from the backend
message since MMIO isn't T2-exclusive.

MFC: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-seuros created this revision.Fri, Aug 14, 8:37 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 14, 8:38 AM

guest-seuros requested review of this revision.Fri, Aug 14, 8:38 AM

Harbormaster completed remote builds in B75582: Diff 184037.Fri, Aug 14, 8:38 AM

LGTM!

This revision is now accepted and ready to land.Mon, Aug 17, 3:11 AM

Closed by commit rG37826269b41b: asmc: prefer MMIO backend over PIO when both are present (authored by guest-seuros, committed by ngie). · Explain WhyMon, Aug 17, 3:13 AM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG37826269b41b: asmc: prefer MMIO backend over PIO when both are present.

Revision Contents
Changeset List

Path

Size

sys/

dev/

asmc/

18 lines

2 lines

Diff 184160

sys/dev/asmc/asmc.c

Loading...

sys/dev/asmc/asmcmmio.c

Loading...