Details

Reviewers

dteske
fuz

Commits

rG9720746c2b51: calendars: Add entry for kfv
rG56ce613f21f2: mailmap: Add entry for kfv
rG6ca41d484d54: committers-src: Add new src committer (kfv)

Summary

Complete src-related steps 5, 6, and 10, as per Committer's Guide §7.1.

Commit Preview

committers-src.dot:

Author: Faraz Vahedi <kfv@FreeBSD.org>
Date:   Fri Aug 7 15:23:22 2026 +0330

    committers-src: Add new src committer (kfv)
    
    Reviewed by:    dteske, fuz
    Approved by:    dteske (mentor), fuz (mentor)
    Differential Revision: https://reviews.freebsd.org/D58700

.mailmap:

Author: Faraz Vahedi <kfv@FreeBSD.org>
Date:   Fri Aug 7 15:29:19 2026 +0330

    mailmap: Add entry for kfv
    
    Reviewed by:    dteske, fuz
    Approved by:    dteske (mentor), fuz (mentor)
    Differential Revision: https://reviews.freebsd.org/D58700

calendars/calendar.freebsd:

Author: Faraz Vahedi <kfv@FreeBSD.org>
Date:   Fri Aug 7 15:30:53 2026 +0330

    calendars: Add entry for kfv
    
    Reviewed by:    dteske, fuz
    Approved by:    dteske (mentor), fuz (mentor)
    Differential Revision: https://reviews.freebsd.org/D58700

Note: metadata may change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kfv created this revision.Fri, Aug 7, 12:03 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 7, 12:03 PM

kfv requested review of this revision.Fri, Aug 7, 12:03 PM

Harbormaster completed remote builds in B75428: Diff 183609.Fri, Aug 7, 12:03 PM

Include mailmap and committers-src commits

Harbormaster completed remote builds in B75429: Diff 183610.Fri, Aug 7, 12:12 PM

I'll update the patch with the required metadata fields once it's approved.
Please let me know if there's anything else that needs to be addressed.

Thanks!

Alternative to .mailmap is freefall:/var/forward/kfv

This revision is now accepted and ready to land.Fri, Aug 7, 4:48 PM

Before you commit, can you update the summary to include the proposed commit message?

Update commit messages; will update metadata if fuz@ provides approval by the time we commit.

This revision now requires review to proceed.Sat, Aug 8, 12:04 PM

Harbormaster completed remote builds in B75454: Diff 183681.Sat, Aug 8, 12:04 PM

kfv edited the summary of this revision. (Show Details)Sat, Aug 8, 12:12 PM

In D58700#1347007, @dteske wrote:

Alternative to .mailmap is freefall:/var/forward/kfv

I don't think .mailmap is related to our freefall email forwarding, it’s only used by Git to map multiple email addresses/names to a single canonical identity.

In D58700#1347010, @dteske wrote:

Before you commit, can you update the summary to include the proposed commit message?

Sure. Done.

Looking good here.

Approved for commit.

This revision is now accepted and ready to land.Sat, Aug 8, 3:43 PM

In D58700#1347447, @kfv wrote:

In D58700#1347007, @dteske wrote:

Alternative to .mailmap is freefall:/var/forward/kfv

I don't think .mailmap is related to our freefall email forwarding, it’s only used by Git to map multiple email addresses/names to a single canonical identity.

👍

In D58700#1347010, @dteske wrote:

Before you commit, can you update the summary to include the proposed commit message?

Sure. Done.

Thanks

On the proposed commit messages, I think Robert (@fuz) will agree, I think we would put:

Reviewed by: dteske, fuz
Approved by: dteske (mentor), fuz (mentor)

In the proposed commit message, there's a typo:

commiters

Change to:

committers

In D58700#1347628, @dteske wrote:
On the proposed commit messages, I think Robert (@fuz) will agree, I think we would put:
Reviewed by: dteske, fuz
Approved by: dteske (mentor), fuz (mentor)
Or if Robert wants, co-mentor.

Yeah, that's good.

Update metadata with Robert’s approval and fix typo from the opening commit

This revision now requires review to proceed.Sat, Aug 8, 11:49 PM

Harbormaster completed remote builds in B75467: Diff 183702.Sat, Aug 8, 11:49 PM

kfv edited the summary of this revision. (Show Details)Sat, Aug 8, 11:51 PM

Thank you both. I really appreciate all your help and support.