Follow-up r295924: Only sync hash-based db files open for writing when closing.
ClosedPublic
Actions

Authored by bdrewery on Apr 6 2016, 10:37 PM.

Tags

None

Referenced Files

	F168003388: D5868.id14953.diff
	Tue, Aug 25, 9:01 PM

	F168002959: D5868.diff
	Tue, Aug 25, 8:59 PM

	F167975674: D5868.id14953.diff
	Tue, Aug 25, 5:26 PM

	Unknown Object (File)
	Mon, Aug 24, 5:12 PM

	Unknown Object (File)
	Mon, Aug 24, 5:09 PM

	Unknown Object (File)
	Mon, Aug 24, 4:59 PM

	Unknown Object (File)
	Mon, Aug 24, 4:58 PM

	Unknown Object (File)
	Mon, Aug 24, 5:55 AM

Subscribers

Details

Reviewers

bapt

Commits

rS297626: Follow-up r295924: Only sync hash-based db files open for writing when closing.

Summary

This fixes a major performance regression when reading db files such as
the pw database during a 'pkg install'.

MFC after: 1 week
Tested by: bapt
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdrewery updated this revision to Diff 14952.Apr 6 2016, 10:37 PM

bdrewery retitled this revision from to Follow-up r295924: Only sync hash-based db files open for writing when closing..

bdrewery updated this object.

bdrewery edited the test plan for this revision. (Show Details)

bdrewery added a reviewer: bapt.

bdrewery added subscribers: garga, vangyzen, se.

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2016, 10:37 PM

bapt accepted this revision.Apr 6 2016, 10:37 PM

bapt edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2016, 10:37 PM

Closed by commit rS297626: Follow-up r295924: Only sync hash-based db files open for writing when closing. (authored by bdrewery). · Explain WhyApr 6 2016, 10:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

db/

hash/

hash.c

3 lines

Diff 14953

View Options

head/lib/libc/db/hash/hash.c

Follow-up r295924: Only sync hash-based db files open for writing when closing.ClosedPublicActions