if_bnxt: drop redundant PCI disable in bnxt_fw_reset_close()
AcceptedPublic
Actions

Authored by sumit.saxena_broadcom.com on Aug 3 2026, 1:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 8:47 AM

	Unknown Object (File)
	Thu, Aug 27, 3:16 PM

	Unknown Object (File)
	Wed, Aug 26, 3:39 PM

	Unknown Object (File)
	Tue, Aug 25, 4:42 AM

	Unknown Object (File)
	Mon, Aug 24, 2:28 AM

	Unknown Object (File)
	Sat, Aug 22, 10:43 PM

	Unknown Object (File)
	Fri, Aug 21, 10:04 PM

	Unknown Object (File)
	Fri, Aug 21, 7:40 PM

View All 15 Files

Subscribers

None

Details

Reviewers

chandrakanth.patil_broadcom.com
sreekanth.reddy_broadcom.com
gallatin
shurd

Summary

bnxt_fw_reset_close() unconditionally called pci_disable_device()
after freeing the Rx IRQs, on every firmware reset, not just the
BNXT_STATE_FW_FATAL_COND path which already disables the device via
bnxt_fw_fatal_close(). BNXT_FW_RESET_STATE_ENABLE_DEV in
bnxt_fw_reset_task() already re-enables the device unconditionally,
so this wasn't leaving the device disabled, just adding an
unnecessary PCI disable/re-enable cycle around every non-fatal reset.