Page MenuHomeFreeBSD

if_bnxt: drop redundant PCI disable in bnxt_fw_reset_close()
ClosedPublic

Authored by sumit.saxena_broadcom.com on Aug 3 2026, 1:09 PM.
Tags
None
Referenced Files
F175355877: D58619.diff
Sat, Oct 10, 6:13 AM
F175342584: D58619.id183298.diff
Sat, Oct 10, 3:38 AM
Unknown Object (File)
Thu, Oct 8, 3:45 PM
Unknown Object (File)
Sat, Oct 3, 6:59 AM
Unknown Object (File)
Fri, Oct 2, 5:02 AM
Unknown Object (File)
Thu, Oct 1, 7:04 AM
Unknown Object (File)
Thu, Oct 1, 7:02 AM
Unknown Object (File)
Mon, Sep 28, 3:46 PM
Subscribers

Details

Summary

bnxt_fw_reset_close() unconditionally called pci_disable_device()
after freeing the Rx IRQs, on every firmware reset, not just the
BNXT_STATE_FW_FATAL_COND path which already disables the device via
bnxt_fw_fatal_close(). BNXT_FW_RESET_STATE_ENABLE_DEV in
bnxt_fw_reset_task() already re-enables the device unconditionally,
so this wasn't leaving the device disabled, just adding an
unnecessary PCI disable/re-enable cycle around every non-fatal reset.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable