Differential D58616

if_bnxt: Never ARM Tx CQ as they are not interrupt-driven
ClosedPublic
Actions

Authored by sumit.saxena_broadcom.com on Aug 3 2026, 1:05 PM.

Tags

None

Referenced Files

	F175376168: D58616.diff
	Sat, Oct 10, 9:50 AM

	Unknown Object (File)
	Wed, Oct 7, 11:54 PM

	Unknown Object (File)
	Mon, Oct 5, 10:30 AM

	Unknown Object (File)
	Thu, Oct 1, 12:57 AM

	Unknown Object (File)
	Wed, Sep 30, 8:47 AM

	Unknown Object (File)
	Sun, Sep 27, 6:32 PM

	Unknown Object (File)
	Fri, Sep 11, 11:28 AM

	Unknown Object (File)
	Sep 1 2026, 1:43 AM

View All 28 Files

Subscribers

Details

Reviewers

chandrakanth.patil_broadcom.com
sreekanth.reddy_broadcom.com
gallatin
shurd

Commits

rG7781529f31b6: if_bnxt: Never ARM Tx CQ as they are not interrupt-driven

Summary

Tx completion rings are not interrupt-driven, so there is no need to
ring the doorbell with CQ_ARMALL and toggle bits set for them. Stop
arming the Tx CQ doorbell on P5+, which makes tx_cp_rings[]->toggle
dead, so drop the now-unnecessary toggle bookkeeping for it in
process_nq() too.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sumit.saxena_broadcom.com created this revision.Aug 3 2026, 1:05 PM

Herald added a reviewer: shurd. · View Herald TranscriptAug 3 2026, 1:05 PM

sumit.saxena_broadcom.com requested review of this revision.Aug 3 2026, 1:05 PM

gallatin accepted this revision.Aug 4 2026, 8:27 PM

This revision is now accepted and ready to land.Aug 4 2026, 8:27 PM

Closed by commit rG7781529f31b6: if_bnxt: Never ARM Tx CQ as they are not interrupt-driven (authored by sumit.saxena_broadcom.com). · Explain WhyFri, Oct 9, 10:13 AM

This revision was automatically updated to reflect the committed changes.

sumit.saxena_broadcom.com added a commit: rG7781529f31b6: if_bnxt: Never ARM Tx CQ as they are not interrupt-driven.

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 10:13 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bnxt/

bnxt_en/

4 lines

Diff 189203

sys/dev/bnxt/bnxt_en/if_bnxt.c

Loading...