Differential D58608

if_bnxt: honor firmware min wait before VER_GET on reset
ClosedPublic
Actions

Authored by sumit.saxena_broadcom.com on Aug 3 2026, 12:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 6, 6:38 PM

	Unknown Object (File)
	Sun, Oct 4, 7:55 AM

	Unknown Object (File)
	Sat, Oct 3, 7:16 PM

	Unknown Object (File)
	Fri, Oct 2, 5:58 PM

	Unknown Object (File)
	Mon, Sep 28, 3:19 PM

	Unknown Object (File)
	Sun, Sep 27, 9:09 AM

	Unknown Object (File)
	Sat, Sep 26, 6:42 PM

	Unknown Object (File)
	Sat, Sep 26, 5:26 AM

View All 37 Files

Subscribers

Details

Reviewers

chandrakanth.patil_broadcom.com
sreekanth.reddy_broadcom.com
gallatin
shurd

Commits

rGe009e1fd8083: if_bnxt: honor firmware min wait before VER_GET on reset

Summary

The firmware advertises a minimum wait time it needs before it is
ready. The driver was not honoring it and sent VER_GET too early
during firmware error-recovery, which could return an incomplete
VER_GET buffer. Enforce that minimum wait, measured from when the
RESET_NOTIFY async event arrived, before sending VER_GET.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sumit.saxena_broadcom.com created this revision.Aug 3 2026, 12:20 PM

Herald added a reviewer: shurd. · View Herald TranscriptAug 3 2026, 12:20 PM

sumit.saxena_broadcom.com requested review of this revision.Aug 3 2026, 12:20 PM

gallatin accepted this revision.Aug 4 2026, 8:10 PM

gallatin added inline comments.

sys/dev/bnxt/bnxt_en/if_bnxt.c
1944	Ick, I hate lkpi. We should not have jiffies, this is BSD. Ick!

This revision is now accepted and ready to land.Aug 4 2026, 8:10 PM

Closed by commit rGe009e1fd8083: if_bnxt: honor firmware min wait before VER_GET on reset (authored by sumit.saxena_broadcom.com). · Explain WhyFri, Oct 9, 10:13 AM

This revision was automatically updated to reflect the committed changes.

sumit.saxena_broadcom.com added a commit: rGe009e1fd8083: if_bnxt: honor firmware min wait before VER_GET on reset.

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 10:13 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bnxt/

bnxt_en/

2 lines

19 lines

Diff 189194

sys/dev/bnxt/bnxt_en/bnxt.h

Loading...

sys/dev/bnxt/bnxt_en/if_bnxt.c

Loading...