Page MenuHomeFreeBSD

if_bnxt: honor firmware min wait before VER_GET on reset
AcceptedPublic

Authored by sumit.saxena_broadcom.com on Aug 3 2026, 12:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 9:03 AM
Unknown Object (File)
Fri, Sep 4, 3:54 PM
Unknown Object (File)
Thu, Sep 3, 2:31 AM
Unknown Object (File)
Wed, Sep 2, 9:29 PM
Unknown Object (File)
Tue, Aug 25, 10:33 PM
Unknown Object (File)
Tue, Aug 25, 4:39 PM
Unknown Object (File)
Mon, Aug 24, 4:32 PM
Unknown Object (File)
Sun, Aug 23, 5:45 PM
Subscribers
None

Details

Summary

The firmware advertises a minimum wait time it needs before it is
ready. The driver was not honoring it and sent VER_GET too early
during firmware error-recovery, which could return an incomplete
VER_GET buffer. Enforce that minimum wait, measured from when the
RESET_NOTIFY async event arrived, before sending VER_GET.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gallatin added inline comments.
sys/dev/bnxt/bnxt_en/if_bnxt.c
1959

Ick, I hate lkpi. We should not have *jiffies*, this is BSD. Ick!

This revision is now accepted and ready to land.Aug 4 2026, 8:10 PM