if_bnxt: add CAGR interrupt coalescing tick-resolution support
Needs ReviewPublic
Actions

Authored by sumit.saxena_broadcom.com on Mon, Aug 3, 12:06 PM.

Details

Reviewers

chandrakanth.patil_broadcom.com
sreekanth.reddy_broadcom.com
gallatin
shurd

Summary

Add the P7 CAGR (Completion AGgregation Ring) NQ-aggregation timer
tick-resolution knob, programmed via a direct GRC-window register
write, with a new dev.bnxt.<unit>.cagr_tick_res read-only tunable.
This is independent of the existing per-ring AGGINT_PARAMS coalescing.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sumit.saxena_broadcom.com created this revision.Mon, Aug 3, 12:06 PM

Herald added a reviewer: shurd. · View Herald TranscriptMon, Aug 3, 12:06 PM

sumit.saxena_broadcom.com requested review of this revision.Mon, Aug 3, 12:06 PM

Does something need to re-apply this after reset?

Also, please run these through style(9).

sys/dev/bnxt/bnxt_en/if_bnxt.c
2080	Does this really need inline?
2091	Is bar=1 correct? Doesn't that land in the hwrm range? Convention seems to be 0 or 2.
2949	Does this override the tunable? If so, is that intended?