Page MenuHomeFreeBSD

packages/tests: Fix gtest dependency
ClosedPublic

Authored by ivy on Thu, Jul 30, 1:47 PM.

Details

Summary

The MFC of 1d0ae66d3c21 (packages subdir build) added a dependency
from FreeBSD-tests on FreeBSD-googletest. However, the googletest
package doesn't exist in 15 because the relevant commit wasn't MFC'd.
This caused a broken and unresolvable dependency.

Replace the incorrect googletest dependency with a dependency on
utilities.

This is a direct commit to stable/15.

Fixes: 1d0ae66d3c21 ("packages: Convert world to a subdir build")
Reported by: Mark Millard <marklmi@yahoo.com>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.Thu, Jul 30, 1:47 PM

Have we explicitly decided that we won't MFC the googletest addition (as opposed to having just not gotten to it yet)?

Either way this change is correct for stable/15 right now, but I'd like to ensure that we either revert this along with an eventual MFC or make it clear that we should not MFC.

Have we explicitly decided that we won't MFC the googletest addition (as opposed to having just not gotten to it yet)?

Either way this change is correct for stable/15 right now, but I'd like to ensure that we either revert this along with an eventual MFC or make it clear that we should not MFC.

if you have archives of re@, we discussed this in the thread "pkgbase MFCs for 15.1" back in March (Message-ID: <aaa2Q-EfIFPPvaOc@amaryllis.le-fay.org>), and the consensus was that we'd skip the googletest MFC for 15.1 but might take it for 15.2. so, if we do decide to that, i'll try to remember to un-MFC this change as well :-)

cperciva added a subscriber: cperciva.

LGTM, please commit ASAP and I'll restart the weekly snapshot build.

This revision is now accepted and ready to land.Thu, Jul 30, 4:56 PM
This revision was automatically updated to reflect the committed changes.