amd64: do not allow to set reserved bits in MXCSR for ptrace(PT_SETFPREGS)
ClosedPublic
Actions

Authored by kib on Thu, Jul 30, 4:22 AM.

Details

Reviewers

markj
jhb

Commits

rGcef05c5a62ba: amd64: do not allow to set reserved bits in MXCSR for ptrace(PT_SETFPREGS)

Summary

Also do not mask bits in the mxcsr_mask.  It is ignored by FRSTOR/XRSTOR.

Reported by:    markj

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Thu, Jul 30, 4:22 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jul 30, 4:22 AM

kib requested review of this revision.Thu, Jul 30, 4:22 AM

Have you had a chance to test this under GDB and/or LLDB? I can't imagine they'd be setting any reserved bits so this should be fine.

This revision is now accepted and ready to land.Thu, Jul 30, 12:34 PM

markj accepted this revision.Thu, Jul 30, 2:52 PM

In D58548#1343721, @jhb wrote:

Have you had a chance to test this under GDB and/or LLDB? I can't imagine they'd be setting any reserved bits so this should be fine.

In such case we would get the #GP I believe, for the same reason as in the Mark' syzcaller reproducer.

Closed by commit rGcef05c5a62ba: amd64: do not allow to set reserved bits in MXCSR for ptrace(PT_SETFPREGS) (authored by kib). · Explain WhyThu, Jul 30, 5:09 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGcef05c5a62ba: amd64: do not allow to set reserved bits in MXCSR for ptrace(PT_SETFPREGS).

Revision Contents
Changeset List

Path

Size

sys/

amd64/

exec_machdep.c

17 lines

Diff 183116

View Options

sys/amd64/amd64/exec_machdep.c

amd64: do not allow to set reserved bits in MXCSR for ptrace(PT_SETFPREGS)ClosedPublicActions