Page MenuHomeFreeBSD
Differential D58481

libfetch: Fix handling of connection failures
ClosedPublic
Actions

Authored by markj on Jul 27 2026, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 1:27 PM
Unknown Object (File)
Thu, Sep 3, 11:18 AM
Unknown Object (File)
Sat, Aug 29, 2:03 PM
Unknown Object (File)
Sat, Aug 29, 5:04 AM
Unknown Object (File)
Sat, Aug 29, 2:03 AM
Unknown Object (File)
Fri, Aug 28, 9:03 AM
Unknown Object (File)
Tue, Aug 25, 8:59 PM
Unknown Object (File)
Mon, Aug 24, 9:38 PM
View All 39 Files
Subscribers
imp

Details

Reviewers
des
Commits
rG21101f52147e: libfetch: Fix handling of connection failures
rGb56bd4c44494: libfetch: Fix handling of connection failures
rGb02e02958dad: libfetch: Fix handling of connection failures
Summary

After commit 848f360c8f9a, if one tries to connect to a closed port,
fetch reports "Operation now in progress", which is rather confusing.
Return a more useful error message, restoring the old behaviour.

Fixes: 848f360c8f9a ("libfetch: Apply timeout to connection attempts")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jul 27 2026, 3:24 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 27 2026, 3:24 PM
markj requested review of this revision.Jul 27 2026, 3:24 PM
Harbormaster completed remote builds in B75165: Diff 182791.Jul 27 2026, 3:24 PM
des accepted this revision.Jul 27 2026, 6:46 PM

Please document as a 14.5 issue and expedite MFC (or just let me know and I'll take care of it)

This revision is now accepted and ready to land.Jul 27 2026, 6:46 PM
markj added a comment.Jul 27 2026, 7:36 PM
In D58481#1341864, @des wrote:

Please document as a 14.5 issue and expedite MFC (or just let me know and I'll take care of it)

I'll MFC after 3 days, so it'll land in stable/14 with lots of time before the branch.

Closed by commit rGb02e02958dad: libfetch: Fix handling of connection failures (authored by markj). · Explain WhyJul 27 2026, 11:11 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGb02e02958dad: libfetch: Fix handling of connection failures.
des added a commit: rGb56bd4c44494: libfetch: Fix handling of connection failures.Aug 2 2026, 7:56 PM
des added a commit: rG21101f52147e: libfetch: Fix handling of connection failures.

Revision Contents
Changeset List

PathSize
lib/
libfetch/
4 lines

Diff 182862

View Options

lib/libfetch/common.c

Loading...