Page MenuHomeFreeBSD
Differential D58480

nvmecontrol.8: Explain which power modes are marked with an asterisk
ClosedPublic
Actions

Authored by mail_fbsd2.e4m.org on Mon, Jul 27, 2:47 PM.
Tags
None
Referenced Files
F166079065: D58480.diff
Tue, Aug 11, 2:05 PM
F166023286: D58480.id182790.diff
Tue, Aug 11, 3:27 AM
Unknown Object (File)
Mon, Aug 10, 9:12 PM
Unknown Object (File)
Sat, Aug 8, 5:55 PM
Unknown Object (File)
Sat, Aug 8, 5:47 PM
Unknown Object (File)
Sat, Aug 8, 1:58 PM
Unknown Object (File)
Sat, Aug 8, 1:56 PM
Unknown Object (File)
Sat, Aug 8, 10:07 AM
View All 41 Files
Subscribers
dab
imp
ziaee

Details

Reviewers
michaelo
ziaee
imp
dab
Commits
rG6a2f1e3a06bc: nvmecontrol.8: Explain non-operational power modes
rG868158f7fd2a: nvmecontrol.8: Explain non-operational power modes
Summary

"nvmecontrol power -l ..." lists the available power modes. Non-operational modes are
marked with an asterisk. This needs to be explained in the man page.
While here, add ⟨device-id | namespace-id⟩ to the "nvmecontrol power" synopsis.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mail_fbsd2.e4m.org created this revision.Mon, Jul 27, 2:47 PM
Herald added subscribers: ziaee, dab, imp. · View Herald TranscriptMon, Jul 27, 2:47 PM
mail_fbsd2.e4m.org requested review of this revision.Mon, Jul 27, 2:47 PM
mail_fbsd2.e4m.org updated this revision to Diff 182790.

Now with the correct diff...

mail_fbsd2.e4m.org added a reviewer: michaelo.Mon, Jul 27, 2:59 PM
michaelo requested changes to this revision.Mon, Jul 27, 3:52 PM
michaelo added a reviewer: ziaee.
michaelo added inline comments.
sbin/nvmecontrol/nvmecontrol.8
36

You are from the future.

This revision now requires changes to proceed.Mon, Jul 27, 3:52 PM
imp accepted this revision.Mon, Jul 27, 8:13 PM

This looks fine as is. I usually tweak .Dd dates when I notice :) But this one should be fixed.

dab requested changes to this revision.Tue, Jul 28, 2:03 AM
dab added inline comments.
sbin/nvmecontrol/nvmecontrol.8
36

Agree that this date should be fixed. Otherwise, change LGTM.

ziaee requested changes to this revision.Tue, Jul 28, 4:58 AM
ziaee added inline comments.
sbin/nvmecontrol/nvmecontrol.8
633

In this doc, the quote style is Dq (28 matches), so we should use that.

mail_fbsd2.e4m.org updated this revision to Diff 182912.Tue, Jul 28, 6:31 AM
mail_fbsd2.e4m.org marked 2 inline comments as done.

Fix date and quoting...

michaelo accepted this revision.Tue, Jul 28, 11:07 AM

Can I MFC this after three days? Any objections?

ziaee requested changes to this revision.Tue, Jul 28, 7:50 PM

Yes, please MFC after 3 days.

sbin/nvmecontrol/nvmecontrol.8
633

The Pq that proceeded the Dq in my suggestion is important. Alternatively, you could use an appositive, but Pq Dq is what we want here.

This revision now requires changes to proceed.Tue, Jul 28, 7:50 PM
dab accepted this revision.Wed, Jul 29, 12:56 AM
imp accepted this revision.Wed, Jul 29, 2:55 AM

I'm good with the text and mfc plan.

mail_fbsd2.e4m.org updated this revision to Diff 183021.Wed, Jul 29, 5:33 AM
mail_fbsd2.e4m.org marked 2 inline comments as done.

Adding the overlooked "Pq"

mail_fbsd2.e4m.org added a comment.Wed, Jul 29, 5:41 AM

Just saw that my inline comments apparently never made it. Let's see if we can change that
(this tool and I are not right for each other ;-)).

sbin/nvmecontrol/nvmecontrol.8
36

Interesting. Most people say I live in the past (due to my affinity to ctm and cvs:-)).
Now fixed (no idea what got into me here...)

633

Again what learned (I just took pwd_mkdb.8 as example).

633

The Pq that proceeded the Dq in my suggestion is important. Alternatively, you could use an appositive, but Pq Dq is what we want here.

OK. The email I received contained just "In this doc, the quote style is Dq (28 matches), so we should use that."
So I started to check the doc for "Dq" to see what it does and implemented "Dq". I didn't check the inline
comment -- silently assuming it would contain the same content as the email. So I missed your notes about Pq...

ziaee accepted this revision.Fri, Jul 31, 11:32 PM
ziaee added inline comments.
sbin/nvmecontrol/nvmecontrol.8
633

My bad, I should have been more precise in the message.

This revision is now accepted and ready to land.Fri, Jul 31, 11:32 PM
Closed by commit rG868158f7fd2a: nvmecontrol.8: Explain non-operational power modes (authored by mail_fbsd2.e4m.org, committed by ziaee). · Explain WhyFri, Jul 31, 11:33 PM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rG868158f7fd2a: nvmecontrol.8: Explain non-operational power modes.
mail_fbsd2.e4m.org added inline comments.Sat, Aug 1, 5:40 AM
sbin/nvmecontrol/nvmecontrol.8
633

Not at all. Im still learning this tool and will hopefully remember its peculiarities.

Thanks to you and all others for your patience :-)

ziaee added a commit: rG6a2f1e3a06bc: nvmecontrol.8: Explain non-operational power modes.Wed, Aug 5, 3:56 PM

Revision Contents
Changeset List

PathSize
sbin/
nvmecontrol/
6 lines

Diff 183189

View Options

sbin/nvmecontrol/nvmecontrol.8

Loading...