Page MenuHomeFreeBSD

aq(4): clean up diagnostics and remove dead code
Needs ReviewPublic

Authored by nick_spun.io on Fri, Jul 24, 3:38 PM.
Tags
None
Referenced Files
F164608815: D58436.diff
Sun, Aug 2, 10:15 AM
Unknown Object (File)
Fri, Jul 31, 1:16 PM
Unknown Object (File)
Fri, Jul 31, 6:04 AM
Unknown Object (File)
Fri, Jul 31, 5:37 AM
Unknown Object (File)
Thu, Jul 30, 4:17 AM
Unknown Object (File)
Wed, Jul 29, 3:28 PM
Unknown Object (File)
Wed, Jul 29, 3:18 PM
Unknown Object (File)
Wed, Jul 29, 8:37 AM
Subscribers

Details

Reviewers
adrian
Summary

Non-functional cleanup, no change in behavior.

device_printf() already prefixes each line with the device name, so the
inline "atlantic:" token in the status and error messages produced a
doubled prefix and diverged from the trace macros; remove it so all
output carries one uniform "aqN:" prefix. Compile the RX/TX descriptor
tracers only when AQ_CFG_DEBUG_LVL > 2 and make them no-op macros
otherwise, so the default build no longer pays a cross-TU call plus
argument evaluation per descriptor.

Drop enum aq_dev_state, struct aq_rx_filters, and struct aq_vlan_tag,
which have no remaining references now that VLAN state lives in a
bitstr_t. Replace the four identical aq_sysctl_print_{tx,rx}_{head,tail}
handlers, each carrying a dead write path on a read-only oid, with one
aq_sysctl_print_ring_ptr that selects the accessor from arg2. Reduce the
thermal and PHY-recovery comments to single terse lines that keep the
load-bearing register numbers and the A1-vs-A2 recovery difference.

Signed-off-by: Nick Price <nick@spun.io>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75222
Build 72105: arc lint + arc unit

Event Timeline

Self-review pass: no functional change to this commit. Commit message
amended to carry the Differential Revision reference.

Rebased onto the updated parent; this commit's content is unchanged.

Refreshed after the comment-cleanup rebase of the series.