ietp: guard iicbus_get_addr with devclass check
ClosedPublic
Actions

Authored by guest-seuros on Fri, Jul 24, 11:45 AM.

Details

Reviewers

adrian
wulf

Commits

rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check

Summary

When a USB HID device triggers identify,
the grandparent is usbhid on a USB hub.
Calling iicbus_get_addr() on a non-iicbus device
hits a KASSERT panic.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-seuros created this revision.Fri, Jul 24, 11:45 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jul 24, 11:45 AM

guest-seuros requested review of this revision.Fri, Jul 24, 11:45 AM

Harbormaster completed remote builds in B75085: Diff 182601.Fri, Jul 24, 11:45 AM

adrian accepted this revision.Fri, Jul 24, 2:28 PM

adrian added projects: USB, drivers.

This revision is now accepted and ready to land.Fri, Jul 24, 2:29 PM

adrian added a reviewer: wulf.Fri, Jul 24, 2:29 PM

Closed by commit rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check (authored by guest-seuros, committed by adrian). · Explain WhySat, Jul 25, 2:02 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hid/

ietp.c

11 lines

Diff 182657

View Options

ietp: guard iicbus_get_addr with devclass checkClosedPublicActions