Differential D58364

kern/sys_ptrace: do not skip P2_PTRACEREQ wait for PT_CLEARSTEP/PT_GET_CHILDREN
ClosedPublic
Actions

Authored by kib on Mon, Jul 20, 10:13 PM.

Tags

None

Referenced Files

	F164118108: D58364.diff
	Tue, Jul 28, 9:48 PM

	F164117889: D58364.diff
	Tue, Jul 28, 9:46 PM

	Unknown Object (File)
	Mon, Jul 27, 8:07 PM

	Unknown Object (File)
	Mon, Jul 27, 7:22 AM

	Unknown Object (File)
	Mon, Jul 27, 6:27 AM

	Unknown Object (File)
	Mon, Jul 27, 12:51 AM

	Unknown Object (File)
	Sun, Jul 26, 5:23 PM

	Unknown Object (File)
	Sun, Jul 26, 12:49 PM

View All 25 Files

Subscribers

Details

Reviewers

Commits

rGeca7b25c101a: kern/sys_ptrace: do not skip P2_PTRACEREQ wait for PT_CLEARSTEP/PT_GET_CHILDREN

Summary

Reported by:    markj
Fixes:  d3b7bbee9275 ("ptrace(2): add PT_GET_CHILDREN")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Mon, Jul 20, 10:13 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, Jul 20, 10:13 PM

kib requested review of this revision.Mon, Jul 20, 10:13 PM

markj accepted this revision.Mon, Jul 20, 10:15 PM

This revision is now accepted and ready to land.Mon, Jul 20, 10:15 PM

markj added inline comments.Mon, Jul 20, 10:19 PM

sys/kern/sys_process.c
1244	Actually, this will re-check proc_can_ptrace() even though you tried to skip it above.

Add a control variable for proc_can_ptrace() calls.

This revision now requires review to proceed.Mon, Jul 20, 10:37 PM

markj accepted this revision.Tue, Jul 21, 2:52 AM

This revision is now accepted and ready to land.Tue, Jul 21, 2:52 AM

Closed by commit rGeca7b25c101a: kern/sys_ptrace: do not skip P2_PTRACEREQ wait for PT_CLEARSTEP/PT_GET_CHILDREN (authored by kib). · Explain WhyTue, Jul 21, 2:59 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGeca7b25c101a: kern/sys_ptrace: do not skip P2_PTRACEREQ wait for PT_CLEARSTEP/PT_GET_CHILDREN.

Revision Contents
Changeset List

Path

Size

sys/

kern/

33 lines

Diff 182343

sys/kern/sys_process.c

Loading...