Differential D58332

i386: supply thermal interrupt handler
ClosedPublic
Actions

Authored by rlibby on Sat, Jul 18, 11:56 PM.

Tags

None

Referenced Files

	F163374217: D58332.diff
	Wed, Jul 22, 3:24 PM

	Unknown Object (File)
	Wed, Jul 22, 3:46 AM

	Unknown Object (File)
	Wed, Jul 22, 1:46 AM

	Unknown Object (File)
	Tue, Jul 21, 1:44 AM

Subscribers

Details

Reviewers

kib
olce
koinec_yahoo.co.jp

Commits

rGcb325dcedfa2: i386: supply thermal interrupt handler

Summary

This fixes a build break for i386.

Fixes: 87ba088fa310 ("x86/local_apic.c: Add support for installing a thermal interrupt handler")

Test Plan

It compiles and an i386 vm boots and passes some kyua tests. I have no idea if this works or even makes sense on i386 beyond that.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Sat, Jul 18, 11:56 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jul 18, 11:56 PM

rlibby requested review of this revision.Sat, Jul 18, 11:56 PM

Harbormaster completed remote builds in B74918: Diff 182189.Sat, Jul 18, 11:56 PM

rlibby edited the test plan for this revision. (Show Details)Sat, Jul 18, 11:58 PM

rlibby added reviewers: kib, olce, koinec_yahoo.co.jp.

kib accepted this revision.Sun, Jul 19, 12:50 AM

This revision is now accepted and ready to land.Sun, Jul 19, 12:50 AM

koinec_yahoo.co.jp accepted this revision.Sun, Jul 19, 1:36 AM

Thank you very much for creating this.
I failed to notice the missing handler for i386 when I made my initial proposal. I apologize for that.

Yes, that makes sense.

Closed by commit rGcb325dcedfa2: i386: supply thermal interrupt handler (authored by rlibby). · Explain WhySun, Jul 19, 3:30 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rGcb325dcedfa2: i386: supply thermal interrupt handler.

In D58332#1337715, @koinec_yahoo.co.jp wrote:

Thank you very much for creating this.
I failed to notice the missing handler for i386 when I made my initial proposal. I apologize for that.

No worries, it happens, especially since i386 is disconnected from universe.

Revision Contents
Changeset List

Path

Size

sys/

i386/

i386/

15 lines

Diff 182195

sys/i386/i386/apic_vector.S

Loading...