Differential D58208

hwpstate_intel: Fix i386 build
ClosedPublic
Actions

Authored by aokblast on Mon, Jul 13, 5:29 AM.

Tags

None

Referenced Files

	F163404624: D58208.id181875.diff
	Wed, Jul 22, 10:10 PM

	F163404390: D58208.id181875.diff
	Wed, Jul 22, 10:06 PM

	Unknown Object (File)
	Tue, Jul 21, 10:34 PM

	Unknown Object (File)
	Mon, Jul 20, 10:21 PM

	Unknown Object (File)
	Mon, Jul 20, 10:17 PM

	Unknown Object (File)
	Sun, Jul 19, 1:07 AM

	Unknown Object (File)
	Sat, Jul 18, 7:48 PM

	Unknown Object (File)
	Thu, Jul 16, 9:01 PM

View All 12 Files

Subscribers

Details

Reviewers

olce
adrian
hs.freebsd_id.omnilan.de
jrtc27

Commits

rGbdc0f7678257: hwpstate_intel: Fix i386 build

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aokblast created this revision.Mon, Jul 13, 5:29 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 13, 5:29 AM

aokblast requested review of this revision.Mon, Jul 13, 5:29 AM

Harbormaster completed remote builds in B74760: Diff 181875.Mon, Jul 13, 5:29 AM

aokblast added reviewers: olce, adrian, hs.freebsd_id.omnilan.de.Mon, Jul 13, 5:30 AM

aokblast added a reviewer: jrtc27.

Haven't tried to build it myself, but if that fixes the build, just go ahead. As a side note, I'll post a review removing this code relatively soon.

This revision is now accepted and ready to land.Mon, Jul 13, 9:10 AM

(And, unless you're in a case where the fix is not simple or you fear about possible complications, no need to upload a review for this, just commit the fix.)

jrtc27 added inline comments.Mon, Jul 13, 10:38 AM

sys/x86/cpufreq/hwpstate_intel.c
355	Alternatively I think this minimal diff has the same effect? It's less efficient but who cares, it's an identify method on i386.

(But also happy with the current diff if you'd rather go with that)

@hs.freebsd_id.omnilan.de I have sent you a mail to ask your desired author and mail few days ago. As others might want to compile on i386, I will use Harry Schmalzb. <freebsd@omnilan.de> and commit tomorrow.

sys/x86/cpufreq/hwpstate_intel.c
355	Oh ok. I will reflect your comment before committing this. Thanks!

jrtc27 added inline comments.Fri, Jul 17, 1:31 PM

sys/x86/cpufreq/hwpstate_intel.c
355	Please do test it though, because I have not! :)

Closed by commit rGbdc0f7678257: hwpstate_intel: Fix i386 build (authored by Harry Schmalzb <freebsd@omnilan.de>, committed by aokblast). · Explain WhySun, Jul 19, 1:37 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rGbdc0f7678257: hwpstate_intel: Fix i386 build.

Revision Contents
Changeset List

Path

Size

sys/

x86/

cpufreq/

hwpstate_intel.c

8 lines

Diff 182219

sys/x86/cpufreq/hwpstate_intel.c

Loading...