Fix namespace listing for old NVMe devices
AcceptedPublic
Actions

Authored by mav on Thu, Jul 2, 4:58 PM.

Details

Reviewers

jhb
imp
chuck

Summary

Commit 9e1db51d4b5fc made camcontrol devlist get list of active namespaces from the device instead of iterating through all possible IDs. The problem is that this request is not supported before NVMe 1.1, and in particular by Intel Optane 905P drives. This change reintroduces iteration for devices before NVMe 1.2.

Test Plan

Before:

# nvmecontrol devlist
 nvme0: WD_BLACK SN770 1TB
    nvme0ns1 (953869MB)
 nvme1: INTEL SSDPE21D480GA
 nvme2: INTEL SSDPE21D480GA
 nvme3: INTEL SSDPE21D480GA

After:

# nvmecontrol devlist
 nvme0: WD_BLACK SN770 1TB
    nvme0ns1 (953869MB)
 nvme1: INTEL SSDPE21D480GA
    nvme1ns1 (457862MB)
 nvme2: INTEL SSDPE21D480GA
    nvme2ns1 (457862MB)
 nvme3: INTEL SSDPE21D480GA
    nvme3ns1 (457862MB)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mav created this revision.Thu, Jul 2, 4:58 PM

Herald added a subscriber: dab. · View Herald TranscriptThu, Jul 2, 4:58 PM

mav requested review of this revision.Thu, Jul 2, 4:58 PM

chuck added inline comments.Sun, Jul 5, 5:18 PM

sbin/nvmecontrol/devlist.c
120	I see why this change exists, but it feels weird that a "print" function has a side effect.

imp accepted this revision.Tue, Jul 7, 6:24 PM

This revision is now accepted and ready to land.Tue, Jul 7, 6:24 PM

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

devlist.c

38 lines

Diff 181229

View Options

sbin/nvmecontrol/devlist.c

Fix namespace listing for old NVMe devicesAcceptedPublicActions