Page MenuHomeFreeBSD
Differential D57972

autofs: rename sx lock description for am_lock
ClosedPublic
Actions

Authored by rew on Tue, Jun 30, 8:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 9, 12:16 AM
Unknown Object (File)
Tue, Jul 7, 9:07 PM
Unknown Object (File)
Tue, Jul 7, 9:04 PM
Unknown Object (File)
Tue, Jul 7, 6:38 PM
Unknown Object (File)
Tue, Jul 7, 6:30 PM
Unknown Object (File)
Tue, Jul 7, 9:07 AM
Unknown Object (File)
Tue, Jul 7, 5:19 AM
Unknown Object (File)
Mon, Jul 6, 9:27 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG29b07ef31379: autofs: rename sx lock description for am_lock
Summary

Rename am_lock description from autofslk -> autofs-mount.

The lock description, autofslk, is used as the description for
autofs_softc->sc_lock, which is used to protect autofs requests and the
like as opposed to am_lock which protects autofs nodes for a given
mount.

This change allows witness to distinguish different lock orders for each
lock.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rew created this revision.Tue, Jun 30, 8:30 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 30, 8:30 PM
rew requested review of this revision.Tue, Jun 30, 8:30 PM
Harbormaster completed remote builds in B74429: Diff 181110.Tue, Jun 30, 8:30 PM
rew added a reviewer: kib.Tue, Jun 30, 8:31 PM
kib added inline comments.Tue, Jun 30, 10:11 PM
sys/fs/autofs/autofs_vfsops.c
89

Top and ps use 6-char field to display the wchan name, which for sx locks happen to be the lock name. I suggest "autfsm" or like.

rew updated this revision to Diff 181157.Wed, Jul 1, 9:00 AM

use autfsm for lock description

Harbormaster completed remote builds in B74450: Diff 181157.Wed, Jul 1, 9:00 AM
rew marked an inline comment as done.Wed, Jul 1, 9:02 AM
kib accepted this revision.Wed, Jul 1, 9:05 AM

Change the commit message to reflect the new name.

This revision is now accepted and ready to land.Wed, Jul 1, 9:05 AM
rew added a comment.Wed, Jul 1, 9:19 AM
In D57972#1329617, @kib wrote:

Change the commit message to reflect the new name.

will do

Closed by commit rG29b07ef31379: autofs: rename sx lock description for am_lock (authored by rew). · Explain WhyWed, Jul 1, 9:26 AM
This revision was automatically updated to reflect the committed changes.
rew added a commit: rG29b07ef31379: autofs: rename sx lock description for am_lock.

Revision Contents
Changeset List

PathSize
sys/
fs/
autofs/
2 lines

Diff 181160

View Options

sys/fs/autofs/autofs_vfsops.c

Loading...