libexec/rc/rc.d/dumpon
42	If you're adding quotes, it makes sense to add them here since splitting need not happen twice.
56	These quotes do not affect anything; while it may be useful to add them for consistency, I don't think it makes much sense if other parts are left unquoted but do not need splitting even though splitting is not expected.
64	If you're adding quotes, it makes sense to add them here since `$?` is not supposed to be split.
71	These quotes do not affect anything either.
102	If you're adding quotes, it makes sense to add them here since this is not supposed to be split.

libexec/rc/rc.d/dumpon
38
42	I thin @ngie's intention is to add quotes that are necessary for correctness, and these are not since splitting has already occurred so `$flag` will not be split further.
53
64	`$?` can never be anything other than an integer, so quotes are not needed for correctness.
102	We know that `$name` is a single word and will not be split.

ngie marked 2 inline comments as done.Wed, Jul 15, 12:57 AM

ngie added inline comments.

libexec/rc/rc.d/dumpon
38	👍
42	Yes. Excellent point though @jilles -- I can do that.
53	👍
56	These quotes do not affect anything; while it may be useful to add them for consistency, I don't think it makes much sense if other parts are left unquoted but do not need splitting even though splitting is not expected. Will revert the change.
64	I agree with @des : quoting a builtin variable seems like incorrect pedanticness (unless I'm missing something about how this variable is set).
71	These quotes do not affect anything either. Will revert this change.
102	We know that `$name` is a single word and will not be split. I'll take @jilles's suggestion: it's a best practice to quote here, and I know a lot of engineers who copy examples verbatim without understanding the subtlety of how things like this work.