Page MenuHomeFreeBSD

dumpon: accept "dump" type in fstab
Needs ReviewPublic

Authored by emaste on Mar 10 2022, 5:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 24 2025, 3:45 PM
Unknown Object (File)
Nov 24 2025, 9:36 AM
Unknown Object (File)
Nov 21 2025, 3:02 AM
Unknown Object (File)
Oct 12 2025, 1:36 PM
Unknown Object (File)
Sep 15 2025, 8:22 AM
Unknown Object (File)
Jul 31 2025, 4:26 AM
Unknown Object (File)
Jul 29 2025, 8:52 AM
Unknown Object (File)
Jul 4 2025, 3:36 AM
Subscribers
None

Details

Reviewers
jilles
kevans

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.

PR: 175311

In contrast to the approach in the PR I went with a loop looking for dump first then swap, as dump should take precedence over swap, in e.g.

# Device                Mountpoint      FStype  Options         Dump    Pass#
/dev/nvd0p3             none    swap    sw              0       0
/dev/nvd0p4             none    dump    sw              0       0

or if we want to avoid reading /etc/fstab twice something like

dump_try=
swap_try=
while read dev mp type more ; do
        [ "${type}" = dump -o "${type}" = swap ] || continue
        case ${dev} in
        *.bde|*.eli)
                dumpon_warn_unencrypted
                dev=${dev%.*}
                ;;
        esac
        [ -c "${dev}" ] || continue
        eval ${type}_try=\"\${${type}_try} ${dev}\"
done </etc/fstab
for dev in ${dump_try} ${swap_try}; do
        dumpon_try "${dev}" 2>/dev/null && return 0
done