Differential D57895

libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode
ClosedPublic
Actions

Authored by lwhsu on Fri, Jun 26, 9:32 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

markj
domagoj.stolfa_gmail.com
gnn

Group Reviewers

Commits

rG8e61d8707f8a: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode

Summary

libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode

dt_print_sym() fills the symbol string via snprintf() in non-oformat
mode but the guarding `dtp->dt_oformat != 0 &&` for the dt_printf()
causes the symbol is computed but never emitted.

Fixes:		93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option")
Event:		Halifax Hackathon 202606
Location:	Room 208, Computer Science Building, Dalhousie University
MFC after:	3 days
Sponsored by:	The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lwhsu created this revision.Fri, Jun 26, 9:32 PM

Herald added a reviewer: gnn. · View Herald TranscriptFri, Jun 26, 9:32 PM

Herald added a subscriber: imp. · View Herald Transcript

lwhsu requested review of this revision.Fri, Jun 26, 9:32 PM

Harbormaster completed remote builds in B74314: Diff 180790.Fri, Jun 26, 9:32 PM

markj accepted this revision as: markj.Fri, Jun 26, 9:39 PM

This revision is now accepted and ready to land.Fri, Jun 26, 9:39 PM

Closed by commit rG8e61d8707f8a: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode (authored by lwhsu). · Explain WhySat, Jun 27, 2:26 AM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rG8e61d8707f8a: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode.

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

2 lines

Diff 180802

cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c

Loading...