Page MenuHomeFreeBSD
Differential D57886

iichid(4): Always release interrupt resource
ClosedPublic
Actions

Authored by obiwac on Fri, Jun 26, 2:29 PM.
Tags
None
Referenced Files
F160953638: D57886.diff
Mon, Jun 29, 9:31 AM
F160938795: D57886.id.diff
Mon, Jun 29, 6:35 AM
F160935104: D57886.diff
Mon, Jun 29, 5:37 AM
Unknown Object (File)
Sun, Jun 28, 11:38 PM
Unknown Object (File)
Sun, Jun 28, 8:58 PM
Unknown Object (File)
Sat, Jun 27, 12:36 PM
Subscribers
imp

Details

Reviewers
wulf
aokblast
Commits
rG0cedb626959c: iichid(4): Always release interrupt resource
Summary

We shouldn't just be doing this when IICHID_SAMPLING is not defined. Also I think it's still worth logging that the interrupt setup failed.

Event: Halifax Hackathon 202606
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

obiwac created this revision.Fri, Jun 26, 2:29 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 26, 2:29 PM
obiwac requested review of this revision.Fri, Jun 26, 2:29 PM
Harbormaster completed remote builds in B74303: Diff 180716.Fri, Jun 26, 2:29 PM
obiwac edited the summary of this revision. (Show Details)Fri, Jun 26, 2:29 PM
aokblast accepted this revision.Fri, Jun 26, 6:49 PM

LGTM! irq_res = bus_alloc_resource_any is not guarded with IICHID_SAMPLING. It should be paired.

This revision is now accepted and ready to land.Fri, Jun 26, 6:49 PM
Closed by commit rG0cedb626959c: iichid(4): Always release interrupt resource (authored by obiwac). · Explain WhyFri, Jun 26, 7:00 PM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rG0cedb626959c: iichid(4): Always release interrupt resource.

Revision Contents
Changeset List

PathSize
sys/
dev/
iicbus/
8 lines

Diff 180777

View Options

sys/dev/iicbus/iichid.c

Loading...