MFC after: 1 week
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This broke a couple test cases in test_ping.py https://ci.freebsd.org/job/FreeBSD-main-amd64-test/28886/testReport/ . Here's the fix (EDIT v2):
diff --git i/sbin/ping/tests/test_ping.py w/sbin/ping/tests/test_ping.py index fdf9c875329c..88164c2ab816 100644 --- i/sbin/ping/tests/test_ping.py +++ w/sbin/ping/tests/test_ping.py @@ -431,8 +431,8 @@ class TestPing(SingleVnetTestTemplate): "args": "ping -A -c3 192.0.2.2", "returncode": 2, "stdout": """\ -\x07\x07PING 192.0.2.2 (192.0.2.2): 56 data bytes - +PING 192.0.2.2 (192.0.2.2): 56 data bytes +\x07\x07 --- 192.0.2.2 ping statistics --- 3 packets transmitted, 0 packets received, 100.0% packet loss """, @@ -463,8 +463,8 @@ class TestPing(SingleVnetTestTemplate): "args": "ping -A -c3 2001:db8::2", "returncode": 2, "stdout": """\ -\x07\x07PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2 - +PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2 +\x07\x07 --- 2001:db8::2 ping statistics --- 3 packets transmitted, 0 packets received, 100.0% packet loss """,
Can I go ahead and commit this patch?
Comment Actions
You don't need my permission, but if you want me to review it you'll have to post it properly.