Page MenuHomeFreeBSD
Differential D57763

tests: Fix race condition in aslr_setuid, take 2
ClosedPublic
Actions

Authored by des on Jun 23 2026, 7:46 AM.
Tags
None
Referenced Files
F166297853: D57763.diff
Wed, Aug 12, 6:02 PM
Unknown Object (File)
Mon, Aug 10, 7:34 AM
Unknown Object (File)
Mon, Aug 10, 2:34 AM
Unknown Object (File)
Sun, Aug 9, 4:02 AM
Unknown Object (File)
Sat, Aug 8, 9:52 PM
Unknown Object (File)
Sat, Aug 8, 4:53 PM
Unknown Object (File)
Sat, Aug 8, 11:59 AM
Unknown Object (File)
Sat, Aug 8, 11:20 AM
View All 49 Files
Subscribers
imp

Details

Reviewers
markj
Group Reviewers
tests
Commits
rG86950cf9ffe8: tests: Fix race condition in aslr_setuid, take 2
Summary

Instead of a cloexec pipe, ingest ping's stdout and block until it has
printed its initial summary, then close the pipe and return to the main
test loop. Run ping in quiet mode so it won't mind that stdout is gone.

PR: 296116
MFC after: 1 week
Fixes: 080a4087014e ("tests: Fix race condition in aslr_setuid")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Jun 23 2026, 7:46 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 23 2026, 7:46 AM
des requested review of this revision.Jun 23 2026, 7:46 AM
Harbormaster completed remote builds in B74135: Diff 180351.Jun 23 2026, 7:46 AM
des updated this revision to Diff 180357.Jun 23 2026, 8:33 AM

tweak

Harbormaster completed remote builds in B74138: Diff 180357.Jun 23 2026, 8:33 AM
des added a parent revision: D57765: ping: Flush stdout after printing initial status.Jun 23 2026, 8:34 AM

Note: this only works after D57765, otherwise the initial line is buffered and we block forever.

markj accepted this revision.Jun 23 2026, 2:08 PM
This revision is now accepted and ready to land.Jun 23 2026, 2:08 PM
Closed by commit rG86950cf9ffe8: tests: Fix race condition in aslr_setuid, take 2 (authored by des). · Explain WhyJun 23 2026, 3:21 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG86950cf9ffe8: tests: Fix race condition in aslr_setuid, take 2.
des mentioned this in rG19a496794685: tests: Fix race condition in aslr_setuid.Jul 7 2026, 8:58 PM
des mentioned this in rG8adf49dac1a9: tests: Fix race condition in aslr_setuid.

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
18 lines

Diff 180385

View Options

tests/sys/kern/aslr.c

Loading...