Differential D5776

Implement wait_event_interruptible_timeout.
ClosedPublic
Actions

Authored by np on Mar 30 2016, 1:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 23, 6:02 PM

	Unknown Object (File)
	Jan 12 2025, 9:08 AM

	Unknown Object (File)
	Jan 5 2025, 6:19 PM

	Unknown Object (File)
	Dec 17 2024, 2:39 PM

	Unknown Object (File)
	Nov 22 2024, 7:47 PM

	Unknown Object (File)
	Nov 16 2024, 4:58 PM

	Unknown Object (File)
	Nov 5 2024, 3:43 AM

	Unknown Object (File)
	Oct 7 2024, 4:13 PM

View All 87 Files

Subscribers

Details

Reviewers

dumbbell
• hselasky

Commits

rS297459: Add wait_event_interruptible_timeout to linuxkpi.

Summary

Implement wait_event_interruptible_timeout in the linuxkpi module. It's
needed for upcoming updates to krping (support for fast registration).

Submitted by: Krishnamraju Eraparaju @ Chelsio

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

np updated this revision to Diff 14729.Mar 30 2016, 1:39 AM

np retitled this revision from to Implement wait_event_interruptible_timeout..

np updated this object.

np edited the test plan for this revision. (Show Details)

np added reviewers: dumbbell, • hselasky.

Herald added a subscriber: imp. · View Herald TranscriptMar 30 2016, 1:39 AM

np added a child revision: D5777: Add fastreg support to krping..Mar 30 2016, 1:55 AM

• hselasky added inline comments.Mar 30 2016, 7:00 AM

sys/compat/linuxkpi/common/include/linux/wait.h
117 ↗	(On Diff #14729)	We have a function "linux_timer_jiffies_until()" already. You should use that and remove this macro.
131 ↗	(On Diff #14729)	__ret should be "int" ?
165 ↗	(On Diff #14729)	Either set "__ret" to "int" or cast result of subtraction to "int", because jiffies is long in linux but int in FreeBSD.

Updates based on feedback.

Move linux_timer_jiffies_until to jiffies.h so it's available in wait.h.
Change __ret to int.

Looks good. Just do a amd64 LINT build and check my whitespace comments before commit.

sys/compat/linuxkpi/common/include/linux/wait.h
123 ↗	(On Diff #14744)	Is there a space/TAB style issue above?

This revision is now accepted and ready to land.Mar 30 2016, 6:59 PM

Whitespace nits.

This revision now requires review to proceed.Mar 30 2016, 7:02 PM

• hselasky accepted this revision.Mar 30 2016, 7:05 PM

• hselasky edited edge metadata.

This revision is now accepted and ready to land.Mar 30 2016, 7:05 PM

Closed by commit rS297459: Add wait_event_interruptible_timeout to linuxkpi. (authored by np). · Explain WhyMar 31 2016, 5:12 PM

This revision was automatically updated to reflect the committed changes.

np mentioned this in D5777: Add fastreg support to krping..Mar 31 2016, 5:17 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linuxkpi/

common/

include/

linux/

10 lines

47 lines

src/

10 lines

Diff 14794

head/sys/compat/linuxkpi/common/include/linux/jiffies.h

Loading...

head/sys/compat/linuxkpi/common/include/linux/wait.h

Loading...

head/sys/compat/linuxkpi/common/src/linux_compat.c

Loading...