ClosedPublic
Actions

Authored by jhb on Mon, Jun 22, 6:51 PM.

Details

Reviewers

bz
emaste

Commits

rG0e0d46422657: LinuxKPI: Retire <linux/dma-attrs.h>

Summary

Move the attribute constants to <linux/dma-mapping.h> to match
upstream.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mon, Jun 22, 6:51 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptMon, Jun 22, 6:51 PM

jhb requested review of this revision.Mon, Jun 22, 6:51 PM

Harbormaster completed remote builds in B74109: Diff 180316.Mon, Jun 22, 6:51 PM

emaste accepted this revision.Mon, Jun 22, 6:59 PM

emaste added inline comments.

sys/compat/linuxkpi/common/include/linux/dma-attrs.h
43–52	these are not used anywhere?

This revision is now accepted and ready to land.Mon, Jun 22, 6:59 PM

jhb added inline comments.Mon, Jun 22, 7:15 PM

sys/compat/linuxkpi/common/include/linux/dma-attrs.h
43–52	No. OFED used to use them, but I've merged upstream commits from Linux to remove their usage. This is an API change upstream Linux made many years ago.

bz added inline comments.Mon, Jun 22, 9:10 PM

sys/compat/linuxkpi/common/include/linux/dma-attrs.h
43–52	When you say many years ago, can you lookup the version. I do not know how far back drm-kmod goes in terms of years. Though we could also just check the oldest branch and see that it's no longer used there. Just a better save than sorry. Apart from that I accept.

The Linux commit was part of Linux 4.10. I merged the upstream commit to remove the usage in OFED in rGe4c4c6eeb2a29f7549d28e6ce51fc36125c08e68. The upstream commit referenced in that log is the tree-wide commit for the Linux kernel that covered everything, not just OFED.

Ah, thanks for the explanation; wasn't clear that the same upstream commit also removed the file.
I believe external drm-kmod starts with 4.16 (not that we still support it).

In D57749#1324141, @bz wrote:

Ah, thanks for the explanation; wasn't clear that the same upstream commit also removed the file.
I believe external drm-kmod starts with 4.16 (not that we still support it).

Indeed, the same upstream commit did remove the file as well (just double checked).

Closed by commit rG0e0d46422657: LinuxKPI: Retire <linux/dma-attrs.h> (authored by jhb). · Explain WhyTue, Jun 23, 3:53 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0e0d46422657: LinuxKPI: Retire <linux/dma-attrs.h>.