Page MenuHomeFreeBSD
Differential D57744

acpi_ibm: Support mic mute key
ClosedPublic
Actions

Authored by obiwac on Mon, Jun 22, 2:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 9, 11:48 PM
Unknown Object (File)
Sat, Jul 4, 2:09 PM
Unknown Object (File)
Sat, Jul 4, 2:06 PM
Unknown Object (File)
Sat, Jul 4, 9:06 AM
Unknown Object (File)
Sat, Jul 4, 9:04 AM
Unknown Object (File)
Fri, Jul 3, 10:36 PM
Unknown Object (File)
Fri, Jul 3, 10:33 PM
Unknown Object (File)
Fri, Jul 3, 7:33 PM
View All 25 Files
Subscribers
imp
shuriku_shurik.kiev.ua
ziaee

Details

Reviewers
glebius
olce
Commits
rG7e7f8b2c6641: acpi_ibm: Report mic mute key evdev events
Summary

acpi_ibm: Report mic mute key evdev events

While here, make the naming of micmute_led more consistent.

PR: 296140
Event: Halifax Hackathon 202606
Reported by: David Lundqvist
Co-authored-by: David Lundqvist
Sponsored by: The FreeBSD Foundation

Test Plan

I do not have a machine I can test this on, but, on machines with the mic mute bit set in dev.acpi_ibm.0.availmask:

  • Check setting/unsetting that bit in dev.acpi_ibm.0.eventmask actually prevents that event from being reported.
  • Check this gets reported by evdev and can be seen in libinput debug-events.

At least the Thinkpad P51 should have this.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74143
Build 71026: arc lint + arc unit

Event Timeline

obiwac created this revision.Mon, Jun 22, 2:56 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptMon, Jun 22, 2:56 PM
obiwac requested review of this revision.Mon, Jun 22, 2:56 PM
Harbormaster completed remote builds in B74101: Diff 180301.Mon, Jun 22, 2:56 PM
obiwac updated this revision to Diff 180323.Mon, Jun 22, 7:24 PM

consistent naming + more stuff in manpage

Harbormaster completed remote builds in B74113: Diff 180323.Mon, Jun 22, 7:24 PM
obiwac updated this revision to Diff 180324.Mon, Jun 22, 7:25 PM

update manpage date

Harbormaster completed remote builds in B74114: Diff 180324.Mon, Jun 22, 7:25 PM
obiwac edited the summary of this revision. (Show Details)Mon, Jun 22, 7:25 PM
obiwac edited the summary of this revision. (Show Details)Mon, Jun 22, 7:28 PM
obiwac edited the test plan for this revision. (Show Details)Mon, Jun 22, 7:37 PM
obiwac added a reviewer: glebius.
obiwac edited the summary of this revision. (Show Details)Mon, Jun 22, 7:47 PM
obiwac updated this revision to Diff 180367.Tue, Jun 23, 1:22 PM
obiwac edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B74143: Diff 180367.Tue, Jun 23, 1:22 PM
shuriku_shurik.kiev.ua added a subscriber: shuriku_shurik.kiev.ua.Wed, Jun 24, 5:29 AM
olce accepted this revision.Wed, Jun 24, 2:11 PM
This revision is now accepted and ready to land.Wed, Jun 24, 2:11 PM
obiwac closed this revision.Wed, Jun 24, 2:43 PM
obiwac added a commit: rG7e7f8b2c6641: acpi_ibm: Report mic mute key evdev events.

I forgot to include the Differential Revision: tag 😭

Revision Contents
Changeset List

PathSize
share/
man/
man4/
6 lines
sys/
dev/
acpi_support/
72 lines

Diff 180367

View Options

share/man/man4/acpi_ibm.4

Loading...
View Options

sys/dev/acpi_support/acpi_ibm.c

Loading...