Page MenuHomeFreeBSD

libc: Fix ATOMIC_VAR_INIT visibility
ClosedPublic

Authored by des on Jun 21 2026, 6:05 PM.
Tags
None
Referenced Files
F174812283: D57724.id180242.diff
Tue, Oct 6, 3:54 AM
Unknown Object (File)
Mon, Oct 5, 2:32 PM
Unknown Object (File)
Sun, Oct 4, 6:12 PM
Unknown Object (File)
Sun, Oct 4, 2:32 PM
Unknown Object (File)
Sat, Oct 3, 12:52 PM
Unknown Object (File)
Fri, Oct 2, 10:33 AM
Unknown Object (File)
Fri, Oct 2, 4:07 AM
Unknown Object (File)
Thu, Sep 24, 7:06 PM
Subscribers

Details

Summary

Fixes: 28cecfe27964 ("libc: Restrict ATOMIC_VAR_INIT for C23 conformance")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jun 21 2026, 6:05 PM
des created this revision.

This looks sane, though I've only a minute to look at it before I have to stow my laptop for takeoff. We'll see if it works.

This revision is now accepted and ready to land.Jun 21 2026, 6:11 PM
fuz added a subscriber: fuz.

Looks reasonable.

sys/sys/stdatomic.h
89

Now that I've had a chance to look at this, I'm convinced this is right because in the past __BSD_VISIBLE has meant 'also include obsoleted interfaces that a strict Cxx environment will have removed'. There's no great way to do this generically, and we'll need to remember this in code reviews. I missed this detail when I looked at it on github.

This revision was automatically updated to reflect the committed changes.