Page MenuHomeFreeBSD

backlight(9): Emit brightness changes via devd(8)
AcceptedPublic

Authored by lme on Sat, Jun 20, 5:13 PM.
Tags
None
Referenced Files
F162728833: D57715.diff
Thu, Jul 16, 5:31 AM
Unknown Object (File)
Sat, Jul 4, 8:50 AM
Unknown Object (File)
Fri, Jul 3, 4:38 PM
Unknown Object (File)
Fri, Jul 3, 4:35 PM
Unknown Object (File)
Thu, Jul 2, 6:14 PM
Unknown Object (File)
Thu, Jul 2, 2:40 AM
Unknown Object (File)
Thu, Jul 2, 2:31 AM
Unknown Object (File)
Wed, Jul 1, 9:02 AM
Subscribers

Details

Reviewers
imp
manu
bcr
Summary

Teach backlight(9) to send brightness changes to devd(8), so one does
not need to poll for changes with backlight(8).

Output format:

!system=brightness subsystem=backlight0 type=change notify=42
Test Plan
  • build a kernel
  • run cat /var/run/devd.seqpacket.pipe | grep brightness
  • change the background brightness using backlight(8)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lme requested review of this revision.Sat, Jun 20, 5:13 PM
bcr added a subscriber: bcr.

OK from manpages. Make sure to bump the .Dd to the date when you commit it.

This revision is now accepted and ready to land.Sat, Jun 20, 7:54 PM
imp added inline comments.
sys/dev/backlight/backlight.c
88

So why not use device_get_nameunit(sc->dev) here?

sys/dev/backlight/backlight.c
88

So why not use device_get_nameunit(sc->dev) here?

It's weird. When I change it to

devctl_notify("brightness", device_get_nameunit(sc->dev),
    "change", notify_buf);

I get drmn0 and not backlight0 as value for subsystem.

!system=brightness subsystem=drmn0 type=change notify=19