Page MenuHomeFreeBSD
Differential D5771

Simplify the inthand_t type for x86.
ClosedPublic
Actions

Authored by kib on Mar 29 2016, 8:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 19, 1:01 AM
Unknown Object (File)
Tue, Nov 18, 4:27 PM
Unknown Object (File)
Sun, Nov 16, 9:27 AM
Unknown Object (File)
Sat, Nov 8, 7:42 PM
Unknown Object (File)
Sat, Nov 8, 7:42 PM
Unknown Object (File)
Fri, Oct 31, 10:15 AM
Unknown Object (File)
Fri, Oct 31, 4:43 AM
Unknown Object (File)
Fri, Oct 31, 4:43 AM
View All Files
Subscribers
imp
rpokala

Details

Reviewers
emaste
jhb
Commits
rS297399: Type of the interrupt handlers on x86 cannot be expressed in C.
Summary

Types for the x86 interrupt handler entry points cannot be expressed in C. For i386, the existing type is some approximation, lacking __stdcall attribute and still being wrong for the return type. For amd64, it cannot be even approximated.

Instead, use void (*)(void) which equally serves the purpose, is simpler and allows to unify i386 and amd64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib updated this revision to Diff 14702.Mar 29 2016, 8:52 AM
kib retitled this revision from to Simplify the inthand_t type for x86..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added reviewers: jhb, emaste.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added subscribers: rpokala, imp. · View Herald TranscriptMar 29 2016, 8:52 AM
jhb accepted this revision.Mar 29 2016, 3:12 PM
jhb edited edge metadata.

Fine with me. The things can't be written directly in C anyway so trying to have a fancy prototype is rather pointless.

This revision is now accepted and ready to land.Mar 29 2016, 3:12 PM
Closed by commit rS297399: Type of the interrupt handlers on x86 cannot be expressed in C. (authored by kib). · Explain WhyMar 29 2016, 7:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
include/
2 lines
3 lines
i386/
include/
2 lines
1 line
x86/
include/
7 lines

Diff 14723

View Options

head/sys/amd64/include/intr_machdep.h

Loading...
View Options

head/sys/amd64/include/md_var.h

Loading...
View Options

head/sys/i386/include/intr_machdep.h

Loading...
View Options

head/sys/i386/include/md_var.h

Loading...
View Options

head/sys/x86/include/x86_var.h

Loading...