Page MenuHomeFreeBSD

Simplify the inthand_t type for x86.
ClosedPublic

Authored by kib on Mar 29 2016, 8:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 3:39 AM
Unknown Object (File)
Sun, Nov 24, 8:04 AM
Unknown Object (File)
Fri, Nov 22, 7:27 PM
Unknown Object (File)
Wed, Nov 20, 10:24 AM
Unknown Object (File)
Oct 16 2024, 1:25 PM
Unknown Object (File)
Oct 15 2024, 1:40 AM
Unknown Object (File)
Oct 14 2024, 12:39 AM
Unknown Object (File)
Oct 13 2024, 5:43 AM
Subscribers

Details

Summary

Types for the x86 interrupt handler entry points cannot be expressed in C. For i386, the existing type is some approximation, lacking __stdcall attribute and still being wrong for the return type. For amd64, it cannot be even approximated.

Instead, use void (*)(void) which equally serves the purpose, is simpler and allows to unify i386 and amd64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib retitled this revision from to Simplify the inthand_t type for x86..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added reviewers: jhb, emaste.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
jhb edited edge metadata.

Fine with me. The things can't be written directly in C anyway so trying to have a fancy prototype is rather pointless.

This revision is now accepted and ready to land.Mar 29 2016, 3:12 PM
This revision was automatically updated to reflect the committed changes.