rc.firewall: Use checkyesno for boolean variables
ClosedPublic
Actions

Authored by des on Jun 19 2026, 6:54 PM.

Details

Reviewers

allanjude
kevans

Group Reviewers

Commits

rG90244a31a076: rc.firewall: Use checkyesno for boolean variables
rGec02e4a80fc1: rc.firewall: Use checkyesno for boolean variables
rGa3c077c1ccbe: rc.firewall: Use checkyesno for boolean variables

Summary

Use the checkyesno function from rc.subr instead of hardcoded checks for
boolean variables. Also drop an incorrect comment about the default
logamount value; the actual default is zero (unlimited).

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Jun 19 2026, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2026, 6:54 PM

des requested review of this revision.Jun 19 2026, 6:54 PM

Harbormaster completed remote builds in B74020: Diff 180088.Jun 19 2026, 6:54 PM

des added a child revision: D57679: rc.firewall: Support on-disk lists.Jun 19 2026, 6:54 PM

des added a reviewer: rc.Jun 20 2026, 11:19 AM

allanjude accepted this revision.Thu, Jun 25, 12:40 PM

This revision is now accepted and ready to land.Thu, Jun 25, 12:40 PM

kevans accepted this revision.Thu, Jun 25, 1:55 PM

Closed by commit rGa3c077c1ccbe: rc.firewall: Use checkyesno for boolean variables (authored by des). · Explain WhyFri, Jun 26, 2:40 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGa3c077c1ccbe: rc.firewall: Use checkyesno for boolean variables.

des added a commit: rGec02e4a80fc1: rc.firewall: Use checkyesno for boolean variables.Tue, Jul 7, 6:39 AM

des added a commit: rG90244a31a076: rc.firewall: Use checkyesno for boolean variables.

Revision Contents
Changeset List

Path

Size

libexec/

rc/

rc.firewall

53 lines

Diff 180718

View Options

rc.firewall: Use checkyesno for boolean variablesClosedPublicActions