periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail
ClosedPublic
Actions

Authored by michaelo on Fri, Jun 19, 5:24 PM.

Details

Reviewers

Commits

rG6a7c8c922455: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail

Summary

Introduce a new variable "security_status_loginfail_ignore" to filter unwanted
login failure messages from the daily security checks.

Co-authored-by: Michael Osipov <michaelo@FreeBSD.org>
PR: 295191
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michaelo created this revision.Fri, Jun 19, 5:24 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Jun 19, 5:24 PM

michaelo requested review of this revision.Fri, Jun 19, 5:24 PM

Harbormaster completed remote builds in B74012: Diff 180076.Fri, Jun 19, 5:24 PM

mail_fbsd2.e4m.org added a subscriber: mail_fbsd2.e4m.org.Sat, Jun 20, 4:55 AM

The commit message says "are no" instead of "are not". You might consider something simpler because users can really filter out whatever they want.

Introduce a new variable "security_status_loginfail_ignore" to filter unwanted login failure messages from the daily security checks.

share/man/man5/periodic.conf.5
1041–1043	Rather than egrep(1), say extended regular expression, since egrep is deprecated in POSIX in favor of grep -E. Simplify the text. Users can really filter out whatever they want.

@jrm, reasonable points. Thank you!

Harbormaster completed remote builds in B74068: Diff 180195.Sat, Jun 20, 7:26 PM

michaelo edited the summary of this revision. (Show Details)Sat, Jun 20, 7:26 PM

michaelo marked an inline comment as done.

jrm accepted this revision.Sat, Jun 20, 8:24 PM

This revision is now accepted and ready to land.Sat, Jun 20, 8:24 PM

Closed by commit rG6a7c8c922455: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail (authored by mail_fbsd2.e4m.org, committed by michaelo). · Explain WhySat, Jun 20, 8:35 PM

This revision was automatically updated to reflect the committed changes.

michaelo added a commit: rG6a7c8c922455: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail.

Revision Contents
Changeset List

Path

Size

share/

man/

man5/

periodic.conf.5

6 lines

usr.sbin/

periodic/

etc/

security/

800.loginfail

1 line

Diff 180204

View Options

share/man/man5/periodic.conf.5