Differential D57595

asmc: Refactor sensor detection and sysctl registration
ClosedPublic
Actions

Authored by guest-seuros on Jun 15 2026, 12:45 PM.

Tags

Referenced Files

	F162638326: D57595.diff
	Wed, Jul 15, 7:26 AM

	F162638325: D57595.diff
	Wed, Jul 15, 7:26 AM

	Unknown Object (File)
	Sun, Jul 5, 3:43 PM

	Unknown Object (File)
	Sat, Jul 4, 11:04 AM

	Unknown Object (File)
	Sat, Jul 4, 3:07 AM

	Unknown Object (File)
	Sun, Jun 28, 1:36 AM

	Unknown Object (File)
	Sat, Jun 27, 9:04 AM

	Unknown Object (File)
	Sat, Jun 27, 7:21 AM

View All 19 Files

Subscribers

Details

Reviewers

adrian
ngie

Commits

rG104b311a03e4: asmc: Refactor sensor detection and sysctl registration

Summary

Replace repeated per-sensor-type blocks for voltage, current, power,
and ambient light sensors with table-driven loops.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-seuros created this revision.Jun 15 2026, 12:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2026, 12:45 PM

guest-seuros requested review of this revision.Jun 15 2026, 12:45 PM

Harbormaster completed remote builds in B73879: Diff 179788.Jun 15 2026, 12:45 PM

guest-seuros added projects: apple (x86), drivers.Tue, Jun 16, 1:03 PM

adrian accepted this revision.Tue, Jun 23, 11:05 PM

This revision is now accepted and ready to land.Tue, Jun 23, 11:05 PM

ngie accepted this revision.Wed, Jun 24, 6:20 PM

ngie added inline comments.

sys/dev/asmc/asmc.c
1735–1742	These are common units that can be abbreviated. (not clang-format'ed).

Closed by commit rG104b311a03e4: asmc: Refactor sensor detection and sysctl registration (authored by guest-seuros, committed by adrian). · Explain WhyThu, Jun 25, 2:22 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG104b311a03e4: asmc: Refactor sensor detection and sysctl registration.

Revision Contents
Changeset List

Path

Size

sys/

dev/

asmc/

147 lines

Diff 180588

sys/dev/asmc/asmc.c

Loading...