Page MenuHomeFreeBSD
Differential D57562

md5(1): honor the locale when encoding filenames
Needs ReviewPublic
Actions

Authored by nick_spun.io on Sat, Jun 13, 5:56 PM.
Tags
None
Referenced Files
F162405522: D57562.id179685.diff
Sun, Jul 12, 10:49 PM
Unknown Object (File)
Sat, Jul 4, 1:23 AM
Unknown Object (File)
Thu, Jul 2, 1:04 AM
Unknown Object (File)
Tue, Jun 23, 1:11 PM
Unknown Object (File)
Wed, Jun 17, 8:31 PM
Unknown Object (File)
Mon, Jun 15, 6:05 PM
Unknown Object (File)
Mon, Jun 15, 6:04 PM
Unknown Object (File)
Mon, Jun 15, 8:53 AM
Subscribers
emaste
imp
ziaee

Details

Reviewers
adrian
Summary

We weren't calling setlocale() so safename() was unnecessarily escaping characters regardless of the user's set locale

PR: 295875

(Not sure if the test is really necessary here)

Test Plan

test suites run successfully, new test added

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nick_spun.io created this revision.Sat, Jun 13, 5:56 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Jun 13, 5:56 PM
nick_spun.io requested review of this revision.Sat, Jun 13, 5:56 PM
nick_spun.io edited the summary of this revision. (Show Details)Sat, Jun 13, 8:10 PM
nick_spun.io added a reviewer: adrian.Sat, Jun 13, 8:22 PM
emaste added a subscriber: emaste.Mon, Jun 15, 2:51 PM

Please generate patches with -U999999 to include full context (if you have an update for this review).

Revision Contents
Changeset List

PathSize
sbin/
md5/
6 lines
3 lines
tests/
34 lines

Diff 179685

View Options

sbin/md5/md5.1

Loading...
View Options

sbin/md5/md5.c

Loading...
View Options

sbin/md5/tests/md5_test.sh

Loading...