Differential D57524

lindebugfs: implement debugfs_create_devm_seqfile()
Needs ReviewPublic
Actions

Authored by bz on Wed, Jun 10, 12:09 PM.

Details

Reviewers

None

Group Reviewers

linuxkpi

Summary

Implement debugfs_create_devm_seqfile() keyed by device and a
read function.

XXX I am not really sure where to put all the bits as they do not
seem to really belong in lindebugfs, but also do not really fit
into debugfs.h (rather fs.h?)
I have thus left over a few bits to cleanup in the hope we can
sort the belonings of the implementation out first.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73802
Build 70685: arc lint + arc unit

Event Timeline

bz created this revision.Wed, Jun 10, 12:09 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptWed, Jun 10, 12:09 PM

bz requested review of this revision.Wed, Jun 10, 12:09 PM

Harbormaster completed remote builds in B73802: Diff 179559.Wed, Jun 10, 12:09 PM

Please see the XXX in the proposed commit message for now. I still wonder which headers and implementation files to put these things given they are this weird mix between device binding and debugfs.

I am expecting to move things around as a result so technical or style review maybe after this is sorted and I updated the review.

Anyone any suggestions/comments on where to place these bits?

Revision Contents
Changeset List

Path

Size

sys/

compat/

lindebugfs/

lindebugfs.c

42 lines

linuxkpi/

common/

include/

linux/

debugfs.h

5 lines

Diff 179559

View Options

sys/compat/lindebugfs/lindebugfs.c