procstat binary: do not skip pid if either path or osrel sysctls failed
ClosedPublic
Actions

Authored by kib on Sun, Jun 7, 7:32 AM.

Details

Reviewers

brooks
emaste

Commits

rG9f378397ee89: procstat binary: do not skip pid if either path or osrel sysctls failed

Summary

PR: 295893

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sun, Jun 7, 7:32 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jun 7, 7:32 AM

kib requested review of this revision.Sun, Jun 7, 7:32 AM

kib retitled this revision from procstat binary: do not skip pid if either path or osrel sysctls faile to procstat binary: do not skip pid if either path or osrel sysctls failed.

kib added reviewers: brooks, emaste.

So we'll still emit the warning from kern.proc.pathname, probably fine.

In D57493#1317600, @emaste wrote:

So we'll still emit the warning from kern.proc.pathname, probably fine.

You mean, remove the warning because we print '-' for such binaries, anyway?

I'm not completely sure what I think the behaviour should be (wrt the PR), but IMO regardless this change is an improvement.

This revision is now accepted and ready to land.Mon, Jun 8, 6:41 PM

You mean, remove the warning because we print '-' for such binaries, anyway?

Yeah, I think we can probably omit the warning in this case. But it doesn't matter much.

In D57493#1317605, @emaste wrote:

You mean, remove the warning because we print '-' for such binaries, anyway?

Yeah, I think we can probably omit the warning in this case. But it doesn't matter much.

In fact, it is somewhat inconvenient to do, since the warning is issued by libprocstat and not by the procstat. I think I postpone the warning removal.

Closed by commit rG9f378397ee89: procstat binary: do not skip pid if either path or osrel sysctls failed (authored by kib). · Explain WhyMon, Jun 8, 8:15 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG9f378397ee89: procstat binary: do not skip pid if either path or osrel sysctls failed.