Differential D57447

rc: Bail if /dev/null is not a device
ClosedPublic
Actions

Authored by des on Thu, Jun 4, 4:54 PM.

Tags

None

Referenced Files

	F159352767: D57447.diff
	Sat, Jun 13, 4:50 AM

	F159346077: D57447.id179220.diff
	Sat, Jun 13, 2:56 AM

	F159340226: D57447.diff
	Sat, Jun 13, 1:13 AM

	F159334125: D57447.id179236.diff
	Fri, Jun 12, 11:27 PM

	Unknown Object (File)
	Tue, Jun 9, 10:28 PM

	Unknown Object (File)
	Tue, Jun 9, 5:10 PM

	Unknown Object (File)
	Tue, Jun 9, 10:39 AM

	Unknown Object (File)
	Mon, Jun 8, 10:42 AM

View All 9 Files

Subscribers

Details

Reviewers

emaste
jhb

Commits

rGd09b42a876bb: rc: Bail if /dev/null is not a device
rG5c12023beb94: rc: Bail if /dev/null is not a device
rGb5a96894f67a: rc: Bail if /dev/null is not a device

Summary

On startup, check that /dev/null exists and is a character device.
Otherwise, one of two things will happen: either /dev is a writable
directory and we will immediately create /dev/null as a regular file
and dump garbage into it, or it does not and we will spit out a stream
of error messages about failing to create /dev/null.

PR: 295782
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Thu, Jun 4, 4:54 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jun 4, 4:54 PM

des requested review of this revision.Thu, Jun 4, 4:54 PM

Harbormaster completed remote builds in B73674: Diff 179220.Thu, Jun 4, 4:54 PM

emaste accepted this revision.Thu, Jun 4, 5:15 PM

This revision is now accepted and ready to land.Thu, Jun 4, 5:15 PM

man page

This revision now requires review to proceed.Thu, Jun 4, 9:16 PM

Herald added a subscriber: ziaee. · View Herald TranscriptThu, Jun 4, 9:16 PM

Harbormaster completed remote builds in B73682: Diff 179236.Thu, Jun 4, 9:16 PM

jhb accepted this revision.Fri, Jun 5, 2:48 PM

This revision is now accepted and ready to land.Fri, Jun 5, 2:48 PM

emaste accepted this revision.Fri, Jun 5, 2:53 PM

Closed by commit rGb5a96894f67a: rc: Bail if /dev/null is not a device (authored by des). · Explain WhyFri, Jun 5, 3:53 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGb5a96894f67a: rc: Bail if /dev/null is not a device.

des added a commit: rG5c12023beb94: rc: Bail if /dev/null is not a device.Mon, Jun 8, 11:01 PM

des added a commit: rGd09b42a876bb: rc: Bail if /dev/null is not a device.

Revision Contents
Changeset List

Path

Size

libexec/

rc/

5 lines

share/

man/

man8/

12 lines

Diff 179280

libexec/rc/rc

Loading...

share/man/man8/rc.8

Loading...