Differential D57415
LinuxKPI: Add linux/types.h to pm_qos.h, fixes issue in new drm-kmod patches Authored by siri_racha.ca on Wed, Jun 3, 4:56 PM. Tags Referenced Files
Subscribers
Details false is not a type in C, and false is defined in linux/types.h, so when linux/types.h is not implicitly included, there is a compile error. This is fixed by including linux/types.h in pm_qos.h. This patch is targeted at fixing a compile error in drm-kmod when porting over new stuff.
Diff Detail
Event TimelineComment Actions When I was patching drm-kmod, I got to a patch which didn't compile, upon further investigation I found that the error was within this file, and it was because it was missing types. I'd assume that previously it was implicitly included. Comment Actions Sounds good, I don't remember which specific drm-kmod patch it was, so can I just say something along the lines of "fixes issue when applying patches to drm-kmod from upstream linux source"? Comment Actions Yes, sounds good. It's just so we know which consumer of LinuxKPI needs/triggers things. I sometimes just said "needed by a new version of a wireless driver" for example (if I couldn't remember which of the 7 it was) but that means we know that wireless pull this in. Comment Actions
Yeah, if we can find a rough version, text along the lines of "needed by amdgpu between Linux 6.xx and 6.yy" Comment Actions Should "needed by amdgpu between Linux 6.12, and 6.15" do it? It's a bit of a wide net I will admit. Comment Actions FWIW Linux does not include types.h from pm_qos.h, but it has three other #includes, one of which presumably transitively includes types.h. |