stdio: *memstream: grow the buffer by 1.5x on write

[kevans]

Summary

This improves performance by reducing the number of allocations as we
write into the memstream, both in the fully buffered case with larger
memstreams and also more trivially in the line- and un-buffered case as
they flush back to the underlying buffer more often.

The inspiration for this was taken from Apple's implementation in
https://github.com/apple-oss-distributions/libc, but expanded to include
wmemstream for consistency. I've added a test for the bug that I hit in
libder that caused me to notice this in the first place, and fixed that
bug in this version.

Sponsored by: Klara, Inc.

[des]

lib/libc/stdio/open_memstream.c

35

76

81

you can replace this entire thing with just ckd_add(&growsize, ms->size, ms->size / 2)

lib/libc/tests/stdio/open_memstream2_test.c

191

I'd prefer including a description if it's not too much trouble

223–225

[kevans]

Review feedback: use ckd_add() and add test descriptions

[des]

lib/libc/stdio/open_memstream.c

35

I don't think you actually need <stdbool.h> here

[jhb]

lib/libc/stdio/open_memstream.c

60

I think it would be clearer (and avoid the need for the comment below about leaving newsize unchanged as it would now be more obvious to the reader) if you renamed this to newlen and then you could call growsize below newsize.

80