Page MenuHomeFreeBSD

boot0cfg: Also allow a file as a trailing argument
AcceptedPublic

Authored by jlduran on Thu, May 28, 6:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 8, 8:19 AM
Unknown Object (File)
Mon, Jun 8, 8:13 AM
Unknown Object (File)
Mon, Jun 8, 4:13 AM
Unknown Object (File)
Mon, Jun 8, 3:55 AM
Unknown Object (File)
Sun, Jun 7, 9:26 PM
Unknown Object (File)
Sun, Jun 7, 8:10 PM
Unknown Object (File)
Sun, Jun 7, 8:05 PM
Unknown Object (File)
Sun, Jun 7, 12:09 AM
Subscribers

Details

Reviewers
imp
jhb
Summary

Modify the disk check to allow arbitrary files as the trailing argument
instead of requiring a live GEOM disk provider.

This enables modifying a boot0 binary file in-place before flashing it
to a disk via gpart bootcode, or using it directly as an argument to
mkimg's partition specification, as these tools cannot directly adjust
the parameters of the boot0 boot manager.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I did this modification, mostly to allow using it in conjunction with mkimg (see the next review in the series). I cannot immediately see any downsides of also enabling a file for modification, I also didn't know whom to ask for a review, as boot0cfg's usage is slowly fading away.

Ah! This explains the other issue I had in a review I saw before this.

This revision is now accepted and ready to land.Thu, May 28, 9:20 PM
This revision now requires review to proceed.Fri, May 29, 1:10 AM
This revision is now accepted and ready to land.Fri, May 29, 1:50 AM