Page MenuHomeFreeBSD
Differential D57297

tests: Fix reliability issues in POSIX ACL tests
ClosedPublic
Actions

Authored by des on Thu, May 28, 11:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 21, 3:54 PM
Unknown Object (File)
Sat, Jun 20, 9:14 PM
Unknown Object (File)
Sat, Jun 20, 5:17 PM
Unknown Object (File)
Sat, Jun 20, 10:47 AM
Unknown Object (File)
Sat, Jun 20, 5:19 AM
Unknown Object (File)
Tue, Jun 16, 2:21 AM
Unknown Object (File)
Mon, Jun 8, 10:44 AM
Unknown Object (File)
Mon, Jun 8, 10:33 AM
View All 27 Files
Subscribers
imp
ngie

Details

Reviewers
markj
Group Reviewers
tests
Commits
rG94cba369a3ba: tests: Fix reliability issues in POSIX ACL tests
rG885a35c07b60: tests: Fix reliability issues in POSIX ACL tests
rG05039fda7ee1: tests: Fix reliability issues in POSIX ACL tests
Summary

The ACL tests use UIDs and GIDs 41, 42, and 43 and expect them to be
unassigned. Since GID 43 is now assigned to the audio group, some
tests have begun to fail.

While here, also fix a benign Perl syntax issue in the test runner.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Thu, May 28, 11:46 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, May 28, 11:46 AM
des requested review of this revision.Thu, May 28, 11:46 AM
Harbormaster completed remote builds in B73503: Diff 178807.Thu, May 28, 11:46 AM
markj accepted this revision.Thu, May 28, 12:07 PM
markj added inline comments.
tests/sys/acl/tools-posix.test
92

This line and others still need to be updated if these UIDs/GIDs are claimed, right?

This revision is now accepted and ready to land.Thu, May 28, 12:07 PM
des added inline comments.Thu, May 28, 12:16 PM
tests/sys/acl/tools-posix.test
92

ah shit, I didn't notice it was also using 44 and 45

des updated this revision to Diff 178812.Thu, May 28, 12:23 PM

one more

This revision now requires review to proceed.Thu, May 28, 12:23 PM
Harbormaster completed remote builds in B73505: Diff 178812.Thu, May 28, 12:23 PM
des marked an inline comment as done.Thu, May 28, 12:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 28, 12:28 PM
Closed by commit rG05039fda7ee1: tests: Fix reliability issues in POSIX ACL tests (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rG05039fda7ee1: tests: Fix reliability issues in POSIX ACL tests.
ngie added a subscriber: ngie.Thu, May 28, 3:53 PM

Macro lgtm:

siva mentioned this in D57210: acl/tools-posix.test: use gid=41 to avoid collision with GID_AUDIO.Thu, May 28, 4:41 PM
des added a commit: rG885a35c07b60: tests: Fix reliability issues in POSIX ACL tests.Tue, Jun 2, 4:44 PM
des added a commit: rG94cba369a3ba: tests: Fix reliability issues in POSIX ACL tests.

Revision Contents
Changeset List

PathSize
tests/
sys/
acl/
2 lines
14 lines

Diff 178813

View Options

tests/sys/acl/run

Loading...
View Options

tests/sys/acl/tools-posix.test

Loading...