Page MenuHomeFreeBSD
Differential D57210

acl/tools-posix.test: use gid=41 to avoid collision with GID_AUDIO
AcceptedPublic
Actions

Authored by siva on Sat, May 23, 6:54 PM.

Details

Reviewers
christos
emaste
Summary

This fixes a CI test failure: https://ci.freebsd.org/job/FreeBSD-main-amd64-test/28566/testReport/junit/sys.acl/00/main/

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73426
Build 70309: arc lint + arc unit

Event Timeline

siva created this revision.Sat, May 23, 6:54 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, May 23, 6:54 PM
siva requested review of this revision.Sat, May 23, 6:54 PM
Harbormaster completed remote builds in B73392: Diff 178490.Sat, May 23, 6:54 PM
emaste added a comment.Sat, May 23, 7:04 PM

The test should probably have a comment explaining the gid we've chosen. It's supposed to be an unused group, I take it?

christos accepted this revision.Sat, May 23, 10:00 PM

I agree with Ed. Other than that LGTM.

This revision is now accepted and ready to land.Sat, May 23, 10:00 PM
siva updated this revision to Diff 178557.Mon, May 25, 3:31 PM

Added comment explaining that UID and GID are chosen to be unused.

This revision now requires review to proceed.Mon, May 25, 3:31 PM
Harbormaster completed remote builds in B73426: Diff 178557.Mon, May 25, 3:31 PM
christos accepted this revision.Mon, May 25, 6:56 PM
This revision is now accepted and ready to land.Mon, May 25, 6:56 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
acl/
54 lines

Diff 178557

View Options

tests/sys/acl/tools-posix.test

Loading...