Don't start the random harvester process until timers are working.
ClosedPublic
Actions

Authored by jhb on Mar 22 2016, 10:24 PM.

Details

Reviewers

jmg
markm
delphij
imp

Commits

rS297366: Don't start the random harvester process until timers are working.

Summary

Don't start the random harvester process until timers are working.

This is a no-op currently, but in kernels with earlier AP startup, the
random kthread was trying to use timeouts with sleeps before timers are
working. Wait until SI_SUB_KICK_SCHEDULER to start the random kproc.

Test Plan

booted both amd64 and i386 kernels both with and without early AP startup

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 14533.Mar 22 2016, 10:24 PM

jhb retitled this revision from to Don't start the random harvester process until timers are working..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: markm.

Herald added a reviewer: jmg. · View Herald TranscriptMar 22 2016, 10:24 PM

Herald added a subscriber: imp. · View Herald Transcript

imp accepted this revision.Mar 23 2016, 2:35 AM

imp added a reviewer: imp.

This revision is now accepted and ready to land.Mar 23 2016, 2:35 AM

delphij accepted this revision.Mar 26 2016, 5:31 AM

delphij added a reviewer: delphij.

markm accepted this revision.Mar 27 2016, 1:12 PM

markm edited edge metadata.

Closed by commit rS297366: Don't start the random harvester process until timers are working. (authored by jhb). · Explain WhyMar 28 2016, 9:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Packages

head/

sys/

dev/

random/

random_harvestq.c

3 lines

O3: Kernel Random Numbers Generator

Diff 14697

View Options

head/sys/dev/random/random_harvestq.c

Don't start the random harvester process until timers are working.ClosedPublicActions