Paths

Table of Contentst

Differential D57028

freebsd-update: Skip /etc/ssl/cert.pem
ClosedPublic
Actions

Authored by des on Sat, May 16, 8:33 AM.

Tags

None

Referenced Files

	F157589819: D57028.id177960.diff
	Sat, May 23, 3:32 AM

	Unknown Object (File)
	Thu, May 21, 8:48 PM

	Unknown Object (File)
	Wed, May 20, 9:23 AM

	Unknown Object (File)
	Tue, May 19, 6:00 PM

	Unknown Object (File)
	Tue, May 19, 6:00 PM

	Unknown Object (File)
	Tue, May 19, 6:00 PM

	Unknown Object (File)
	Tue, May 19, 6:00 PM

	Unknown Object (File)
	Tue, May 19, 6:00 PM

Subscribers

Details

Reviewers

Commits

rGa1b3818746e3: freebsd-update: Skip /etc/ssl/cert.pem
rG081a9e933033: freebsd-update: Skip /etc/ssl/cert.pem
rG2709755d39f5: freebsd-update: Skip /etc/ssl/cert.pem
rG55b1142a3642: freebsd-update: Skip /etc/ssl/cert.pem
rGadf56b3107c4: freebsd-update: Skip /etc/ssl/cert.pem
rG7d9c1d3895b3: freebsd-update: Skip /etc/ssl/cert.pem
rGb97f143b6ca9: freebsd-update: Skip /etc/ssl/cert.pem
rG2509ddee9bdb: freebsd-update: Skip /etc/ssl/cert.pem

Summary

We already run certctl rehash at the end, there is no point in asking
users upgrading from 15.0 to 15.1 to manually merge the trust store.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Sat, May 16, 8:33 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, May 16, 8:33 AM

des requested review of this revision.Sat, May 16, 8:33 AM

Harbormaster completed remote builds in B73144: Diff 177919.Sat, May 16, 8:33 AM

vladlen added a subscriber: vladlen.Sat, May 16, 10:01 AM

vladlen added inline comments.

usr.sbin/freebsd-update/freebsd-update.sh
3167	According to certclt(8) option -D must have spaces between it and directory name. [-D destdir] And I suppose BASEDIR can be empty, it will be interpreted as -D rehash

des added inline comments.Sat, May 16, 12:20 PM

usr.sbin/freebsd-update/freebsd-update.sh
3167	According to certclt(8) option -D must have spaces between it and directory name. [-D destdir] No. And I suppose BASEDIR can be empty, it will be interpreted as -D rehash That would be a concern if `BASEDIR` could be empty, but we set it to `/` in `default_params()`.

cperciva added inline comments.Sat, May 16, 10:35 PM

usr.sbin/freebsd-update/freebsd-update.sh
3167	If this is just a cosmetic change, we shouldn't include it in what gets merged to releng branches. Feel free to commit it separately though.

narrow

Harbormaster completed remote builds in B73158: Diff 177960.Sun, May 17, 11:34 AM

cperciva accepted this revision.Mon, May 18, 4:16 PM

This revision is now accepted and ready to land.Mon, May 18, 4:16 PM

Closed by commit rG2509ddee9bdb: freebsd-update: Skip /etc/ssl/cert.pem (authored by des). · Explain WhyMon, May 18, 4:22 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG2509ddee9bdb: freebsd-update: Skip /etc/ssl/cert.pem.

des added a commit: rGb97f143b6ca9: freebsd-update: Skip /etc/ssl/cert.pem.Tue, May 19, 1:59 PM

des added a commit: rG7d9c1d3895b3: freebsd-update: Skip /etc/ssl/cert.pem.

des added a commit: rGadf56b3107c4: freebsd-update: Skip /etc/ssl/cert.pem.

markj added a commit: rG55b1142a3642: freebsd-update: Skip /etc/ssl/cert.pem.Wed, May 20, 7:40 PM

markj added a commit: rG2709755d39f5: freebsd-update: Skip /etc/ssl/cert.pem.

markj added a commit: rG081a9e933033: freebsd-update: Skip /etc/ssl/cert.pem.

markj added a commit: rGa1b3818746e3: freebsd-update: Skip /etc/ssl/cert.pem.

Revision Contents
Changeset List

Path

Size

usr.sbin/

freebsd-update/

freebsd-update.sh

2 lines

Diff 178021

usr.sbin/freebsd-update/freebsd-update.sh

Loading...