wtap: use typed rssi and noise floor values
ClosedPublic
Actions

Authored by bz on Fri, May 15, 5:18 PM.

Details

Reviewers

lwhsu
adrian

Group Reviewers

wireless

Commits

rG7e74f27a5af8: wtap: use typed rssi and noise floor values
rGd201e4e84919: wtap: use typed rssi and noise floor values

Summary

Adjust the rssi and nf arguments to typed int8_t and adjust the maths
for rssi to be consistant with what net80211 expects.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Fri, May 15, 5:18 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, May 15, 5:18 PM

bz requested review of this revision.Fri, May 15, 5:18 PM

Harbormaster completed remote builds in B73135: Diff 177895.Fri, May 15, 5:18 PM

Want to rebase this to use the net80211_rssi_t once that diff lands?

In D57020#1306569, @adrian wrote:

Want to rebase this to use the net80211_rssi_t once that diff lands?

No, this needs to go before that. Well, it technically needs to go before net80211_rssi_t becoming int16_t as the old code breaks the compile otherwise. So yes, update in two steps later.

ok!

This revision is now accepted and ready to land.Fri, May 15, 5:23 PM

lwhsu added inline comments.Fri, May 15, 5:39 PM

sys/dev/wtap/if_wtap.c
539	This seems making value of rssi to 137 (42 + 95) and then 247 (137 * 2) and exceed the range of int8_t?

bz added a child revision: D57021: net80211: define a type for rssi values.Fri, May 15, 5:44 PM

bz marked an inline comment as done.

bz added inline comments.

sys/dev/wtap/if_wtap.c
539	I just added the child revision; there is a link to yet another Dxxxx in it which explains the entire problem and also why @adrian asks if I will update this as well later.