vnlru: avoid trigger calculation when force < 2

[olce]

(Minor: I wouldn't add the braces on the "then" part of if (force < 2).)

[kib]

In D56950#1304667, @olce wrote:

(Minor: I wouldn't add the braces on the "then" part of if (force < 2).)

Normally, if one branch uses {}, other branch should do it as well. So the patch is more style-compliant as is.

[olce]

In D56950#1304757, @kib wrote:

In D56950#1304667, @olce wrote:

(Minor: I wouldn't add the braces on the "then" part of if (force < 2).)

Normally, if one branch uses {}, other branch should do it as well. So the patch is more style-compliant as is.

style(9) says otherwise ("Braces that are not necessary may be left out.", and see the example just below that part).

Besides removing not necessary braces being my personal preference, it would also reduce the diff here (even if admittedly it is quite small so does not make a big difference).

[rlibby]

Regarding braces... I prefer to leave it with the braces. My preference is to apply to both branches if applied to one. Style says "may" be left out. There are many examples of the balanced use, including about 10 in this file.

Also, I realized that I missed moving the vnlru_read_freevnodes() call here. Will update for that. Sorry for the churn.

[rlibby]

Also make the vnlru_read_freevnodes() call conditional.

[olce]

In D56950#1305249, @rlibby wrote:

Regarding braces... I prefer to leave it with the braces. My preference is to apply to both branches if applied to one. Style says "may" be left out. There are many examples of the balanced use, including about 10 in this file.

Yes, "may". I was responding to kib@, who was implying "must not". If there are other uses in the file, fine (well, I might axe them when I get to rewrite this part, but unfortunately this is not going to happen any time soon).