libssl and USE_OPENSSL
AbandonedPublic
Actions

Authored by brnrd on Mar 20 2016, 8:43 PM.

Details

Reviewers

koobs
feld
bdrewery

Group Reviewers

portmgr

Summary

Proposed commit log:

Mk/Scripts/qa.sh: Add check for libcrypto/libssl and USE_OPENSSL

  - Check for binaries linking libcrypto/libssl
  - Emit a warning if USE_OPENSSL is set and doesn't link
  - Emit a warning if USE_OPENSSL is not set and binaries link

Reviewed_by:	feld (mentor), koobs (mentor)
Approved by:	(mentor), (portmgr)
Differential_Revision: D56??

Test Plan

make check-qa on several ports, modified and original

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 2957
Build 2985: arc lint + arc unit

Event Timeline

brnrd updated this revision to Diff 14455.Mar 20 2016, 8:43 PM

brnrd retitled this revision from to Mk/Scripts/qa.sh: Add check for libcrypto/libssl and USE_OPENSSL.

brnrd updated this object.

brnrd edited the test plan for this revision. (Show Details)

brnrd added reviewers: feld, koobs.

Herald added a reviewer: portmgr. · View Herald TranscriptMar 20 2016, 8:43 PM

Herald added a subscriber: mat. · View Herald Transcript

bdrewery requested changes to this revision.Mar 21 2016, 3:48 PM

bdrewery added a reviewer: bdrewery.

bdrewery added a subscriber: bdrewery.

bdrewery added inline comments.

Mk/Scripts/qa.sh
99	Please name this found_ssl. It's too generic while there are 3 different libs being searched for.

This revision now requires changes to proceed.Mar 21 2016, 3:48 PM

Merging back into D5688 again (including change to found_ssl). Makes no sense to have qa.sh here if the request by @mat is to add bsd.port.mk changes to D5688