_decls.h
ClosedPublic
Actions

Authored by kib on Fri, May 8, 2:15 PM.

Details

Reviewers

brooks
markj
imp

Commits

rGea72f6d5a8b9: sys/cdefs.h: move __BEGIN_DECLS/__END_DECLS into a helper sys/_decls.h

Summary

There are situations where nothing from sys/cdefs.h is needed except for
the declaration braces.  More, the other facilities from sys/cdefs.h
might unnecessarly pollute the namespace.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib requested review of this revision.Fri, May 8, 2:15 PM

kib created this revision.

Fix build

markj accepted this revision.Sun, May 10, 5:24 PM

This revision is now accepted and ready to land.Sun, May 10, 5:24 PM

The commit message should explain why...

Not sure about my copyright comment. Retaining it certainly is fine.

sys/sys/_decls.h
6	Imho, This file now has nothing copyrightable in it... there are no creatove choices here. The names of the macros are effectively dicted by the interface, and their contents are fixed by the language...

kib edited the summary of this revision. (Show Details)Sun, May 10, 5:56 PM

kib added inline comments.

sys/sys/_decls.h
6	Ok. Could you please advise what to put into the herald? I do not think that completely removing the copyright block is right, it would cause questions about the status of the header.