libifconfig: Skip bridge VLAN config for span members
ClosedPublic
Actions

Authored by ivy on Tue, Apr 28, 5:00 PM.

Details

Reviewers

zlei
pouria

Group Reviewers

network
bridge

Commits

rG5f901e157aaf: libifconfig: Skip bridge VLAN config for span members
rG0a919e2a9265: libifconfig: Skip bridge VLAN config for span members
rG454322c08b8a: libifconfig: Skip bridge VLAN config for span members

Summary

bridge(4) doesn't support BRDGGIFVLANSET for span members, which
means if a span interface is configured, libifconfig will fail to
fetch bridge members. Skip this for IFBIF_SPAN members.

PR: 292634
MFC after: 3 days
Reported by: Emrion <kmachine@free.fr>
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Tue, Apr 28, 5:00 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 28, 5:00 PM

ivy requested review of this revision.Tue, Apr 28, 5:00 PM

Harbormaster completed remote builds in B72616: Diff 176740.Tue, Apr 28, 5:00 PM

ivy edited the summary of this revision. (Show Details)Tue, Apr 28, 5:26 PM

Looks good to me.

This revision is now accepted and ready to land.Tue, Apr 28, 5:26 PM

pouria accepted this revision as: pouria.Tue, Apr 28, 9:06 PM

Closed by commit rG454322c08b8a: libifconfig: Skip bridge VLAN config for span members (authored by ivy). · Explain WhyWed, Apr 29, 3:18 AM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG454322c08b8a: libifconfig: Skip bridge VLAN config for span members.

ivy added a commit: rG0a919e2a9265: libifconfig: Skip bridge VLAN config for span members.Mon, May 4, 12:16 AM

ivy added a commit: rG5f901e157aaf: libifconfig: Skip bridge VLAN config for span members.Tue, May 5, 3:06 PM

Revision Contents
Changeset List

Path

Size

lib/

libifconfig/

libifconfig_bridge.c

5 lines

Diff 176770

View Options

lib/libifconfig/libifconfig_bridge.c

libifconfig: Skip bridge VLAN config for span membersClosedPublicActions