Page MenuHomeFreeBSD

md5: Don't generate test cases just to skip them
ClosedPublic

Authored by des on Apr 28 2026, 11:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 27, 11:26 PM
Unknown Object (File)
Wed, Jun 17, 10:59 PM
Unknown Object (File)
Tue, Jun 16, 11:58 AM
Unknown Object (File)
Fri, Jun 12, 1:06 PM
Unknown Object (File)
Thu, Jun 4, 2:42 PM
Unknown Object (File)
Wed, Jun 3, 5:44 AM
Unknown Object (File)
Tue, Jun 2, 9:36 PM
Unknown Object (File)
Tue, Jun 2, 4:58 PM
Subscribers

Details

Summary

Don't waste time generating Perl test cases for algorithms that are not
supported in Perl mode only to skip them when they are run.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Apr 28 2026, 11:13 AM
ngie added a subscriber: ngie.
ngie added inline comments.
sbin/md5/tests/md5_test.sh
232

It's worth creating a function that does this eval for you, then add a comment at the head of the function to maintain the DRY best practice and to clarify what the logic is actually doing.

This revision is now accepted and ready to land.Apr 28 2026, 7:52 PM
This revision now requires review to proceed.May 2 2026, 4:29 PM
This revision is now accepted and ready to land.May 5 2026, 6:41 PM
This revision was automatically updated to reflect the committed changes.