Differential D56687

md5: Don't generate test cases just to skip them
ClosedPublic
Actions

Authored by des on Apr 28 2026, 11:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 27, 11:26 PM

	Unknown Object (File)
	Wed, Jun 17, 10:59 PM

	Unknown Object (File)
	Tue, Jun 16, 11:58 AM

	Unknown Object (File)
	Fri, Jun 12, 1:06 PM

	Unknown Object (File)
	Thu, Jun 4, 2:42 PM

	Unknown Object (File)
	Wed, Jun 3, 5:44 AM

	Unknown Object (File)
	Tue, Jun 2, 9:36 PM

	Unknown Object (File)
	Tue, Jun 2, 4:58 PM

View All 53 Files

Subscribers

Details

Reviewers

kevans
ngie

Group Reviewers

Commits

rG9536a3a2de01: md5: Don't generate test cases just to skip them
rGf9626b7e55e1: md5: Don't generate test cases just to skip them
rGfd386e76fa2b: md5: Don't generate test cases just to skip them

Summary

Don't waste time generating Perl test cases for algorithms that are not
supported in Perl mode only to skip them when they are run.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Apr 28 2026, 11:13 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 28 2026, 11:13 AM

des requested review of this revision.Apr 28 2026, 11:13 AM

Harbormaster completed remote builds in B72598: Diff 176709.Apr 28 2026, 11:13 AM

ngie accepted this revision as: ngie.Apr 28 2026, 7:52 PM

ngie added a subscriber: ngie.

ngie added inline comments.

sbin/md5/tests/md5_test.sh
232	It's worth creating a function that does this eval for you, then add a comment at the head of the function to maintain the DRY best practice and to clarify what the logic is actually doing.

This revision is now accepted and ready to land.Apr 28 2026, 7:52 PM

dedup, add comments

This revision now requires review to proceed.May 2 2026, 4:29 PM

Harbormaster completed remote builds in B72722: Diff 177043.May 2 2026, 4:29 PM

minimize

Harbormaster completed remote builds in B72724: Diff 177045.May 2 2026, 4:32 PM

minimize

Harbormaster completed remote builds in B72725: Diff 177046.May 2 2026, 4:35 PM

ngie accepted this revision.May 5 2026, 6:41 PM

This revision is now accepted and ready to land.May 5 2026, 6:41 PM

Closed by commit rGfd386e76fa2b: md5: Don't generate test cases just to skip them (authored by des). · Explain WhyMay 5 2026, 7:45 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGfd386e76fa2b: md5: Don't generate test cases just to skip them.

des added a commit: rGf9626b7e55e1: md5: Don't generate test cases just to skip them.May 7 2026, 6:59 PM

cperciva added a commit: rG9536a3a2de01: md5: Don't generate test cases just to skip them.May 7 2026, 8:19 PM

Revision Contents
Changeset List

Path

Size

sbin/

md5/

tests/

12 lines

Diff 177266

sbin/md5/tests/md5_test.sh

Loading...